• zhaozhao.zz's avatar
    update monitor client's memory and evict correctly (#12420) · 01eb939a
    zhaozhao.zz authored
    A bug introduced in #11657 (7.2 RC1), causes client-eviction (#8687)
    and INFO to have inaccurate memory usage metrics of MONITOR clients.
    
    Because the type in `c->type` and the type in `getClientType()` are confusing
    (in the later, `CLIENT_TYPE_NORMAL` not `CLIENT_TYPE_SLAVE`), the comment
    we wrote in `updateClientMemUsageAndBucket` was wrong, and in fact that function
    didn't skip monitor clients.
    And since it doesn't skip monitor clients, it was wrong to delete the call for it from
    `replicationFeedMonitors` (it wasn't a NOP).
    That deletion could mean that the monitor client memory usage is not always up to
    date (updated less frequently, but still a candidate for client eviction).
    01eb939a
server.c 287 KB