• Huang Zhw's avatar
    When tests exit normally, some processes may still be alive (#8647) · a19c4058
    Huang Zhw authored
    In certain scenario start_server may think it failed to start a redis server
    although it started successfully. in these cases, it'll not terminate it, and
    it'll remain running when the test is over.
    
    In start_server if config doesn't have bind (the minimal.conf in introspection.tcl),
    it will try to bind ipv4 and ipv6. One may success while other fails. It will
    output "Could not create server TCP listening socket".
    wait_server_started uses this message to check whether instance started
    successfully. So it will consider that it failed even though redis started successfully.
    
    Additionally, in some cases it wasn't clear to users why the server exited,
    since the warning message printed to the log, could in some cases be harmless,
    and in some cases fatal.
    
    This PR adds makes a clear distinction between a warning log message and
    a fatal one, and changes the test suite to look for the fatal message.
    a19c4058
server.c 230 KB