Unverified Commit 21aabab4 authored by Harkrishn Patro's avatar Harkrishn Patro Committed by GitHub
Browse files

Fix acl dryrun to return the tested common permission error. (#10359)

parent dff153ff
...@@ -2799,7 +2799,7 @@ setuser_cleanup: ...@@ -2799,7 +2799,7 @@ setuser_cleanup:
sds err = sdsempty(); sds err = sdsempty();
if (result == ACL_DENIED_CMD) { if (result == ACL_DENIED_CMD) {
err = sdscatfmt(err, "This user has no permissions to run " err = sdscatfmt(err, "This user has no permissions to run "
"the '%s' command", c->cmd->fullname); "the '%s' command", cmd->fullname);
} else if (result == ACL_DENIED_KEY) { } else if (result == ACL_DENIED_KEY) {
err = sdscatfmt(err, "This user has no permissions to access " err = sdscatfmt(err, "This user has no permissions to access "
"the '%s' key", c->argv[idx + 3]->ptr); "the '%s' key", c->argv[idx + 3]->ptr);
......
...@@ -305,6 +305,12 @@ start_server {tags {"acl external:skip"}} { ...@@ -305,6 +305,12 @@ start_server {tags {"acl external:skip"}} {
assert_equal "ERR Command 'not-a-command' not found" $e assert_equal "ERR Command 'not-a-command' not found" $e
} }
test {Test various commands for command permissions} {
r ACL setuser command-test -@all
assert_equal "This user has no permissions to run the 'set' command" [r ACL DRYRUN command-test set somekey somevalue]
assert_equal "This user has no permissions to run the 'get' command" [r ACL DRYRUN command-test get somekey]
}
test {Test various odd commands for key permissions} { test {Test various odd commands for key permissions} {
r ACL setuser command-test +@all %R~read* %W~write* %RW~rw* r ACL setuser command-test +@all %R~read* %W~write* %RW~rw*
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment