Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
ruanhaishen
redis
Commits
244b873b
Commit
244b873b
authored
Jun 11, 2010
by
Pieter Noordhuis
Browse files
make sure the value to insert is string encoded
parent
bcfb3876
Changes
2
Hide whitespace changes
Inline
Side-by-side
redis.c
View file @
244b873b
...
...
@@ -5091,6 +5091,7 @@ static robj *listTypeGet(listTypeEntry *entry) {
static
void
listTypeInsert
(
listTypeEntry
*
entry
,
robj
*
value
,
int
where
)
{
robj
*
subject
=
entry
->
li
->
subject
;
if
(
entry
->
li
->
encoding
==
REDIS_ENCODING_ZIPLIST
)
{
value
=
getDecodedObject
(
value
);
if
(
where
==
REDIS_TAIL
)
{
unsigned
char
*
next
=
ziplistNext
(
subject
->
ptr
,
entry
->
zi
);
...
...
@@ -5104,6 +5105,7 @@ static void listTypeInsert(listTypeEntry *entry, robj *value, int where) {
}
else
{
subject
->
ptr
=
ziplistInsert
(
subject
->
ptr
,
entry
->
zi
,
value
->
ptr
,
sdslen
(
value
->
ptr
));
}
decrRefCount
(
value
);
}
else
if
(
entry
->
li
->
encoding
==
REDIS_ENCODING_LIST
)
{
if
(
where
==
REDIS_TAIL
)
{
listInsertNode
(
subject
->
ptr
,
entry
->
ln
,
value
,
AL_START_TAIL
);
...
...
tests/unit/type/list.tcl
View file @
244b873b
...
...
@@ -73,6 +73,8 @@ start_server {
assert_equal 8
[
r linsert xlist before a aa
]
assert_equal 8
[
r linsert xlist before bad aaa
]
assert_equal
{
aa a b zz c yy d dd
}
[
r lrange xlist 0 10
]
assert_equal 9
[
r linsert xlist before aa 42
]
assert_equal 42
[
r lrange xlist 0 0
]
}
test
{
LPUSHX, RPUSHX, LPUSHXAFTER, RPUSHXAFTER - regular list
}
{
...
...
@@ -98,6 +100,8 @@ start_server {
assert_equal 8
[
r linsert xlist before a aa
]
assert_equal 8
[
r linsert xlist before bad aaa
]
assert_equal
{
aa a aaaaaaaaaaaaaaaaa zz c yy d dd
}
[
r lrange xlist 0 10
]
assert_equal 9
[
r linsert xlist before aa 42
]
assert_equal 42
[
r lrange xlist 0 0
]
}
test
{
DEL a list - ziplist
}
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment