Unverified Commit 311a757c authored by Oran Agra's avatar Oran Agra Committed by GitHub
Browse files

Some adjustments to command hints. (#10375)

* stats and latency commands have non-deterministic output.
* the ones about latency should be sent to ALL_NODES (considering
  reads from replicas)
* the ones about running scripts and memory usage only to masters.
* stats aggregation is SPECIAL (like in INFO)
parent 86ca9b25
...@@ -3449,8 +3449,9 @@ struct redisCommandArg FUNCTION_RESTORE_Args[] = { ...@@ -3449,8 +3449,9 @@ struct redisCommandArg FUNCTION_RESTORE_Args[] = {
/* FUNCTION STATS tips */ /* FUNCTION STATS tips */
const char *FUNCTION_STATS_tips[] = { const char *FUNCTION_STATS_tips[] = {
"nondeterministic_output",
"request_policy:all_shards", "request_policy:all_shards",
"response_policy:one_succeeded", "response_policy:special",
NULL NULL
}; };
...@@ -4381,7 +4382,12 @@ struct redisCommandArg LATENCY_GRAPH_Args[] = { ...@@ -4381,7 +4382,12 @@ struct redisCommandArg LATENCY_GRAPH_Args[] = {
#define LATENCY_HISTOGRAM_History NULL #define LATENCY_HISTOGRAM_History NULL
/* LATENCY HISTOGRAM tips */ /* LATENCY HISTOGRAM tips */
#define LATENCY_HISTOGRAM_tips NULL const char *LATENCY_HISTOGRAM_tips[] = {
"nondeterministic_output",
"request_policy:all_nodes",
"response_policy:special",
NULL
};
/* LATENCY HISTOGRAM argument table */ /* LATENCY HISTOGRAM argument table */
struct redisCommandArg LATENCY_HISTOGRAM_Args[] = { struct redisCommandArg LATENCY_HISTOGRAM_Args[] = {
...@@ -4395,7 +4401,12 @@ struct redisCommandArg LATENCY_HISTOGRAM_Args[] = { ...@@ -4395,7 +4401,12 @@ struct redisCommandArg LATENCY_HISTOGRAM_Args[] = {
#define LATENCY_HISTORY_History NULL #define LATENCY_HISTORY_History NULL
/* LATENCY HISTORY tips */ /* LATENCY HISTORY tips */
#define LATENCY_HISTORY_tips NULL const char *LATENCY_HISTORY_tips[] = {
"nondeterministic_output",
"request_policy:all_nodes",
"response_policy:special",
NULL
};
/* LATENCY HISTORY argument table */ /* LATENCY HISTORY argument table */
struct redisCommandArg LATENCY_HISTORY_Args[] = { struct redisCommandArg LATENCY_HISTORY_Args[] = {
...@@ -4409,7 +4420,12 @@ struct redisCommandArg LATENCY_HISTORY_Args[] = { ...@@ -4409,7 +4420,12 @@ struct redisCommandArg LATENCY_HISTORY_Args[] = {
#define LATENCY_LATEST_History NULL #define LATENCY_LATEST_History NULL
/* LATENCY LATEST tips */ /* LATENCY LATEST tips */
#define LATENCY_LATEST_tips NULL const char *LATENCY_LATEST_tips[] = {
"nondeterministic_output",
"request_policy:all_nodes",
"response_policy:special",
NULL
};
/********** LATENCY RESET ********************/ /********** LATENCY RESET ********************/
...@@ -4417,7 +4433,11 @@ struct redisCommandArg LATENCY_HISTORY_Args[] = { ...@@ -4417,7 +4433,11 @@ struct redisCommandArg LATENCY_HISTORY_Args[] = {
#define LATENCY_RESET_History NULL #define LATENCY_RESET_History NULL
/* LATENCY RESET tips */ /* LATENCY RESET tips */
#define LATENCY_RESET_tips NULL const char *LATENCY_RESET_tips[] = {
"request_policy:all_nodes",
"response_policy:all_succeeded",
NULL
};
/* LATENCY RESET argument table */ /* LATENCY RESET argument table */
struct redisCommandArg LATENCY_RESET_Args[] = { struct redisCommandArg LATENCY_RESET_Args[] = {
...@@ -4505,6 +4525,8 @@ NULL ...@@ -4505,6 +4525,8 @@ NULL
/* MEMORY STATS tips */ /* MEMORY STATS tips */
const char *MEMORY_STATS_tips[] = { const char *MEMORY_STATS_tips[] = {
"nondeterministic_output", "nondeterministic_output",
"request_policy:all_shards",
"response_policy:special",
NULL NULL
}; };
......
...@@ -15,8 +15,9 @@ ...@@ -15,8 +15,9 @@
"SCRIPTING" "SCRIPTING"
], ],
"command_tips": [ "command_tips": [
"NONDETERMINISTIC_OUTPUT",
"REQUEST_POLICY:ALL_SHARDS", "REQUEST_POLICY:ALL_SHARDS",
"RESPONSE_POLICY:ONE_SUCCEEDED" "RESPONSE_POLICY:SPECIAL"
] ]
} }
} }
...@@ -13,6 +13,11 @@ ...@@ -13,6 +13,11 @@
"LOADING", "LOADING",
"STALE" "STALE"
], ],
"command_tips": [
"NONDETERMINISTIC_OUTPUT",
"REQUEST_POLICY:ALL_NODES",
"RESPONSE_POLICY:SPECIAL"
],
"arguments": [ "arguments": [
{ {
"name": "COMMAND", "name": "COMMAND",
......
...@@ -13,6 +13,11 @@ ...@@ -13,6 +13,11 @@
"LOADING", "LOADING",
"STALE" "STALE"
], ],
"command_tips": [
"NONDETERMINISTIC_OUTPUT",
"REQUEST_POLICY:ALL_NODES",
"RESPONSE_POLICY:SPECIAL"
],
"arguments": [ "arguments": [
{ {
"name": "event", "name": "event",
......
...@@ -12,6 +12,11 @@ ...@@ -12,6 +12,11 @@
"NOSCRIPT", "NOSCRIPT",
"LOADING", "LOADING",
"STALE" "STALE"
],
"command_tips": [
"NONDETERMINISTIC_OUTPUT",
"REQUEST_POLICY:ALL_NODES",
"RESPONSE_POLICY:SPECIAL"
] ]
} }
} }
...@@ -13,6 +13,10 @@ ...@@ -13,6 +13,10 @@
"LOADING", "LOADING",
"STALE" "STALE"
], ],
"command_tips": [
"REQUEST_POLICY:ALL_NODES",
"RESPONSE_POLICY:ALL_SUCCEEDED"
],
"arguments": [ "arguments": [
{ {
"name": "event", "name": "event",
......
...@@ -8,7 +8,9 @@ ...@@ -8,7 +8,9 @@
"container": "MEMORY", "container": "MEMORY",
"function": "memoryCommand", "function": "memoryCommand",
"command_tips": [ "command_tips": [
"NONDETERMINISTIC_OUTPUT" "NONDETERMINISTIC_OUTPUT",
"REQUEST_POLICY:ALL_SHARDS",
"RESPONSE_POLICY:SPECIAL"
] ]
} }
} }
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment