Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
ruanhaishen
redis
Commits
64e588bf
Commit
64e588bf
authored
Apr 27, 2020
by
antirez
Browse files
Rework comment in dictEncObjKeyCompare().
parent
0d1e8c93
Changes
1
Show whitespace changes
Inline
Side-by-side
src/server.c
View file @
64e588bf
...
@@ -1219,16 +1219,15 @@ int dictEncObjKeyCompare(void *privdata, const void *key1,
...
@@ -1219,16 +1219,15 @@ int dictEncObjKeyCompare(void *privdata, const void *key1,
o2
->
encoding
==
OBJ_ENCODING_INT
)
o2
->
encoding
==
OBJ_ENCODING_INT
)
return
o1
->
ptr
==
o2
->
ptr
;
return
o1
->
ptr
==
o2
->
ptr
;
/* due to OBJ_STATIC_REFCOUNT, we rather not call sdsEncodedObject unnecessarily */
/* Due to OBJ_STATIC_REFCOUNT, we avoid calling getDecodedObject() without
if
(
!
sdsEncodedObject
(
o1
))
* good reasons, because it would incrRefCount() the object, which
o1
=
getDecodedObject
(
o1
);
* is invalid. So we check to make sure dictFind() works with static
if
(
!
sdsEncodedObject
(
o2
))
* objects as well. */
o2
=
getDecodedObject
(
o2
);
if
(
!
sdsEncodedObject
(
o1
))
o1
=
getDecodedObject
(
o1
);
if
(
!
sdsEncodedObject
(
o2
))
o2
=
getDecodedObject
(
o2
);
cmp
=
dictSdsKeyCompare
(
privdata
,
o1
->
ptr
,
o2
->
ptr
);
cmp
=
dictSdsKeyCompare
(
privdata
,
o1
->
ptr
,
o2
->
ptr
);
if
(
o1
!=
key1
)
if
(
o1
!=
key1
)
decrRefCount
(
o1
);
decrRefCount
(
o1
);
if
(
o2
!=
key2
)
decrRefCount
(
o2
);
if
(
o2
!=
key2
)
decrRefCount
(
o2
);
return
cmp
;
return
cmp
;
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment