Unverified Commit 762be79f authored by Meir Shpilraien (Spielrein)'s avatar Meir Shpilraien (Spielrein) Committed by GitHub
Browse files

Disable new SIGABRT test on valgrind (#8013)

The crash reports cause false-positive warnings when run with valgrind.
parent 639b73cd
set server_path [tmpdir server.log]
set system_name [string tolower [exec uname -s]] set system_name [string tolower [exec uname -s]]
if {$system_name eq {linux} || $system_name eq {darwin}} { if {$system_name eq {linux} || $system_name eq {darwin}} {
set server_path [tmpdir server.log]
start_server [list overrides [list dir $server_path]] { start_server [list overrides [list dir $server_path]] {
test "Server is able to generate a stack trace on selected systems" { test "Server is able to generate a stack trace on selected systems" {
r config set watchdog-period 200 r config set watchdog-period 200
...@@ -21,10 +21,11 @@ if {$system_name eq {linux} || $system_name eq {darwin}} { ...@@ -21,10 +21,11 @@ if {$system_name eq {linux} || $system_name eq {darwin}} {
} }
} }
} }
}
set server_path [tmpdir server1.log] # Valgrind will complain that the process terminated by a signal, skip it.
start_server [list overrides [list dir $server_path]] { if {!$::valgrind} {
set server_path [tmpdir server1.log]
start_server [list overrides [list dir $server_path]] {
test "Crash report generated on SIGABRT" { test "Crash report generated on SIGABRT" {
set pid [s process_id] set pid [s process_id]
exec kill -SIGABRT $pid exec kill -SIGABRT $pid
...@@ -32,4 +33,7 @@ start_server [list overrides [list dir $server_path]] { ...@@ -32,4 +33,7 @@ start_server [list overrides [list dir $server_path]] {
set result [exec tail -1000 < [srv 0 stdout]] set result [exec tail -1000 < [srv 0 stdout]]
assert {[string match $pattern $result]} assert {[string match $pattern $result]}
} }
}
}
} }
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment