Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
ruanhaishen
redis
Commits
770cb0ba
Commit
770cb0ba
authored
Feb 19, 2020
by
Guy Benoish
Browse files
XGROUP DESTROY should unblock XREADGROUP with -NOGROUP
parent
df45fed0
Changes
2
Hide whitespace changes
Inline
Side-by-side
src/t_stream.c
View file @
770cb0ba
...
...
@@ -1850,6 +1850,8 @@ NULL
server
.
dirty
++
;
notifyKeyspaceEvent
(
NOTIFY_STREAM
,
"xgroup-destroy"
,
c
->
argv
[
2
],
c
->
db
->
id
);
/* We want to unblock any XREADGROUP consumers with -NOGROUP. */
signalKeyAsReady
(
c
->
db
,
c
->
argv
[
2
]);
}
else
{
addReply
(
c
,
shared
.
czero
);
}
...
...
tests/unit/type/stream-cgroups.tcl
View file @
770cb0ba
...
...
@@ -161,6 +161,15 @@ start_server {
assert
{[
$rd
read
]
==
{}}
;
# before the fix, client didn't even block, but was served synchronously with
{
mystream
{}}
}
test
{
XGROUP DESTROY should unblock XREADGROUP with -NOGROUP
}
{
r del mystream
r XGROUP CREATE mystream mygroup $ MKSTREAM
set rd
[
redis_deferring_client
]
$rd XREADGROUP GROUP mygroup Alice BLOCK 100 STREAMS mystream
">"
r XGROUP DESTROY mystream mygroup
assert_error
"*NOGROUP*"
{
$rd
read
}
}
test
{
XCLAIM can claim PEL items from another consumer
}
{
# Add 3 items into the stream, and create a consumer group
r del mystream
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment