Commit 86b5e1a7 authored by Oran Agra's avatar Oran Agra
Browse files

Add some additional signal info to the crash log (#7891)

- si_code can be very useful info some day.
- a clear indication that redis was killed by an external user

(cherry picked from commit f659d236)
parent bab83457
...@@ -1627,7 +1627,7 @@ void sigsegvHandler(int sig, siginfo_t *info, void *secret) { ...@@ -1627,7 +1627,7 @@ void sigsegvHandler(int sig, siginfo_t *info, void *secret) {
bugReportStart(); bugReportStart();
serverLog(LL_WARNING, serverLog(LL_WARNING,
"Redis %s crashed by signal: %d", REDIS_VERSION, sig); "Redis %s crashed by signal: %d, si_code: %d", REDIS_VERSION, sig, info->si_code);
if (eip != NULL) { if (eip != NULL) {
serverLog(LL_WARNING, serverLog(LL_WARNING,
"Crashed running the instruction at: %p", eip); "Crashed running the instruction at: %p", eip);
...@@ -1636,6 +1636,9 @@ void sigsegvHandler(int sig, siginfo_t *info, void *secret) { ...@@ -1636,6 +1636,9 @@ void sigsegvHandler(int sig, siginfo_t *info, void *secret) {
serverLog(LL_WARNING, serverLog(LL_WARNING,
"Accessing address: %p", (void*)info->si_addr); "Accessing address: %p", (void*)info->si_addr);
} }
if (info->si_pid != -1) {
serverLog(LL_WARNING, "Killed by PID: %d, UID: %d", info->si_pid, info->si_uid);
}
serverLog(LL_WARNING, serverLog(LL_WARNING,
"Failed assertion: %s (%s:%d)", server.assert_failed, "Failed assertion: %s (%s:%d)", server.assert_failed,
server.assert_file, server.assert_line); server.assert_file, server.assert_line);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment