Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
ruanhaishen
redis
Commits
aba68552
Commit
aba68552
authored
Jul 20, 2018
by
antirez
Browse files
Clarify that clientsCronTrackExpansiveClients() indexes may jump ahead.
parent
be88c0b1
Changes
1
Show whitespace changes
Inline
Side-by-side
src/server.c
View file @
aba68552
...
@@ -909,7 +909,15 @@ int clientsCronTrackExpansiveClients(client *c) {
...
@@ -909,7 +909,15 @@ int clientsCronTrackExpansiveClients(client *c) {
/* Always zero the next sample, so that when we switch to that second, we'll
/* Always zero the next sample, so that when we switch to that second, we'll
* only register samples that are greater in that second without considering
* only register samples that are greater in that second without considering
* the history of such slot. */
* the history of such slot.
*
* Note: our index may jump to any random position if serverCron() is not
* called for some reason with the normal frequency, for instance because
* some slow command is called taking multiple seconds to execute. In that
* case our array may end containing data which is potentially older
* than CLIENTS_PEAK_MEM_USAGE_SLOTS seconds: however this is not a problem
* since here we want just to track if "recently" there were very expansive
* clients from the POV of memory usage. */
ClientsPeakMemInput
[
zeroidx
]
=
0
;
ClientsPeakMemInput
[
zeroidx
]
=
0
;
ClientsPeakMemOutput
[
zeroidx
]
=
0
;
ClientsPeakMemOutput
[
zeroidx
]
=
0
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment