1. 28 Oct, 2013 1 commit
  2. 19 Aug, 2013 2 commits
    • antirez's avatar
      Fix comments for correctness in zunionInterGenericCommand(). · 3039e806
      antirez authored
      Related to issue #1240.
      3039e806
    • antirez's avatar
      Properly init/release iterators in zunionInterGenericCommand(). · cfb9d025
      antirez authored
      This commit does mainly two things:
      
      1) It fixes zunionInterGenericCommand() by removing mass-initialization
      of all the iterators used, so that we don't violate the unsafe iterator
      API of dictionaries. This fixes issue #1240.
      
      2) Since the zui* APIs required the allocator to be initialized in the
      zsetopsrc structure in order to use non-iterator related APIs, this
      commit fixes this strict requirement by accessing objects directly via
      the op->subject->ptr pointer we have to the object.
      cfb9d025
  3. 22 Jul, 2013 1 commit
    • antirez's avatar
      Introduction of a new string encoding: EMBSTR · 894eba07
      antirez authored
      Previously two string encodings were used for string objects:
      
      1) REDIS_ENCODING_RAW: a string object with obj->ptr pointing to an sds
      stirng.
      
      2) REDIS_ENCODING_INT: a string object where the obj->ptr void pointer
      is casted to a long.
      
      This commit introduces a experimental new encoding called
      REDIS_ENCODING_EMBSTR that implements an object represented by an sds
      string that is not modifiable but allocated in the same memory chunk as
      the robj structure itself.
      
      The chunk looks like the following:
      
      +--------------+-----------+------------+--------+----+
      | robj data... | robj->ptr | sds header | string | \0 |
      +--------------+-----+-----+------------+--------+----+
                           |                       ^
                           +-----------------------+
      
      The robj->ptr points to the contiguous sds string data, so the object
      can be manipulated with the same functions used to manipulate plan
      string objects, however we need just on malloc and one free in order to
      allocate or release this kind of objects. Moreover it has better cache
      locality.
      
      This new allocation strategy should benefit both the memory usage and
      the performances. A performance gain between 60 and 70% was observed
      during micro-benchmarks, however there is more work to do to evaluate
      the performance impact and the memory usage behavior.
      894eba07
  4. 29 Jan, 2013 1 commit
  5. 28 Jan, 2013 2 commits
  6. 19 Jan, 2013 1 commit
  7. 22 Nov, 2012 1 commit
  8. 08 Nov, 2012 1 commit
  9. 23 May, 2012 1 commit
    • antirez's avatar
      Fixed issue #516 (ZINTERSTORE mixing sets and zsets). · 348ee1a4
      antirez authored
      Weeks ago trying to fix an harmless GCC warning I introduced a bug in
      the ziplist-encoded implementations of sorted sets.
      
      The bug completely broke zuiNext() iterator, that is used in the
      ZINTERSTORE and ZUNIONSTORE implementation, so those two commands are no
      longer reliable starting from Redis version 2.4.12 and latest 2.6.0-RC
      releases.
      
      This commit fixes the problem and adds a regression test.
      348ee1a4
  10. 24 Apr, 2012 1 commit
  11. 22 Feb, 2012 1 commit
  12. 21 Feb, 2012 1 commit
  13. 16 Jan, 2012 1 commit
  14. 11 Jan, 2012 1 commit
  15. 23 Dec, 2011 1 commit
  16. 19 Dec, 2011 1 commit
    • BigCat's avatar
      Fix issue #247 : Accepting non-integer parameters when shouldn't · 706b32e0
      BigCat authored
      Using `getLongFromObjectOrReply` instead of `atoi` if possible.
      The following functions are modified.
      
      * lrangeCommand
      * ltrimCommand
      * lremCommand
      * lindexCommand
      * lsetCommand
      * zunionInterGenericCommand
      * genericZrangebyscoreCommand
      * sortCommand
      706b32e0
  17. 18 Dec, 2011 1 commit
  18. 14 Nov, 2011 1 commit
  19. 08 Nov, 2011 1 commit
  20. 23 Oct, 2011 1 commit
  21. 04 Oct, 2011 1 commit
  22. 03 Oct, 2011 2 commits
  23. 31 May, 2011 2 commits
  24. 24 May, 2011 1 commit
  25. 19 May, 2011 2 commits
  26. 15 May, 2011 2 commits
  27. 04 May, 2011 1 commit
  28. 28 Apr, 2011 1 commit
  29. 06 Apr, 2011 2 commits
  30. 21 Mar, 2011 1 commit
  31. 14 Mar, 2011 2 commits
  32. 11 Mar, 2011 1 commit