1. 24 Feb, 2015 1 commit
  2. 11 Feb, 2015 1 commit
    • antirez's avatar
      SPOP with count: initial fixes to the implementation. · 6b5922dc
      antirez authored
      Severan problems are addressed but still a few missing.
      Since replication of this command was more complex than others since it
      needs to replicate multiple SREM commands, an old API able to do this
      was reused (it was taken inside the implementation since it was pretty
      obvious soon or later that would be useful). The API was improved a bit
      so that now a command may opt-out for the standard command replication
      when the server.dirty counter is incremented, in order to "manually"
      replicate what it wants.
      6b5922dc
  3. 03 Feb, 2015 1 commit
    • antirez's avatar
      Handle redis-check-rdb as a standalone program. · 7d1e1580
      antirez authored
      This also makes it backward compatible in the usage, but for the command
      name. However the old command name was less obvious so it is worth to
      break it probably.
      
      With the new setup the program main can perform argument parsing and
      everything else useful for an RDB check regardless of the Redis server
      itself.
      7d1e1580
  4. 28 Jan, 2015 1 commit
    • Matt Stancliff's avatar
      Convert check-dump to Redis check-rdb mode · 145473ac
      Matt Stancliff authored
      redis-check-dump is now named redis-check-rdb and it runs
      as a mode of redis-server instead of an independent binary.
      
      You can now use 'redis-server redis.conf --check-rdb' to check
      the RDB defined in redis.conf.  Using argument --check-rdb
      checks the RDB and exits.  We could potentially also allow
      the server to continue starting if the RDB check succeeds.
      
      This change also enables us to use RDB checking programatically
      from inside Redis for certain failure conditions.
      145473ac
  5. 19 Jan, 2015 1 commit
    • Matt Stancliff's avatar
      Improve networking type correctness · 53c082ec
      Matt Stancliff authored
      read() and write() return ssize_t (signed long), not int.
      
      For other offsets, we can use the unsigned size_t type instead
      of a signed offset (since our replication offsets and buffer
      positions are never negative).
      53c082ec
  6. 13 Jan, 2015 1 commit
    • antirez's avatar
      Cluster: clusterMsgDataGossip structure, explict padding + minor stuff. · 5b0f4a83
      antirez authored
      Also explicitly set version to 0, add a protocol version define, improve
      comments in the gossip structure.
      
      Note that the structure layout is the same after the change, we are just
      making the padding explicit with an additional not used 16 bits field.
      So this commit is still able to talk with the previous versions of
      cluster nodes.
      5b0f4a83
  7. 09 Jan, 2015 2 commits
  8. 02 Jan, 2015 2 commits
  9. 23 Dec, 2014 2 commits
    • Matt Stancliff's avatar
      Allow all code tests to run using Redis args · 8febcffd
      Matt Stancliff authored
      Previously, many files had individual main() functions for testing,
      but each required being compiled with their own testing flags.
      That gets difficult when you have 8 different flags you need
      to set just to run all tests (plus, some test files required
      other files to be compiled aaginst them, and it seems some didn't
      build at all without including the rest of Redis).
      
      Now all individual test main() funcions are renamed to a test
      function for the file itself and one global REDIS_TEST define enables
      testing across the entire codebase.
      
      Tests can now be run with:
        - `./redis-server test <test>`
      
        e.g. ./redis-server test ziplist
      
      If REDIS_TEST is not defined, then no tests get included and no
      tests are included in the final redis-server binary.
      8febcffd
    • Matt Stancliff's avatar
      Add addReplyBulkSds() function · ad41a7c4
      Matt Stancliff authored
      Refactor a common pattern into one function so we don't
      end up with copy/paste programming.
      ad41a7c4
  10. 18 Dec, 2014 1 commit
    • Alon Diamant's avatar
      Fix: case when SPOP with count>MAXINT, setTypeRandomElements() will get... · 3c8a7558
      Alon Diamant authored
      Fix: case when SPOP with count>MAXINT, setTypeRandomElements() will get negative count argument due to signed/unsigned mismatch.
      
      setTypeRandomElements() now returns unsigned long, and also uses unsigned long for anything related to count of members.
      spopWithCountCommand() now uses unsigned long elements_returned instead of int, for values returned from setTypeRandomElements()
      3c8a7558
  11. 14 Dec, 2014 1 commit
    • Alon Diamant's avatar
      Added <count> parameter to SPOP: · 28802887
      Alon Diamant authored
      spopCommand() now runs spopWithCountCommand() in case the <count> param is found.
      Added intsetRandomMembers() to Intset: Copies N random members from the set into inputted 'values' array. Uses either the Knuth or Floyd sample algos depending on ratio count/size.
      Added setTypeRandomElements() to SET type: Returns a number of random elements from a non empty set. This is a version of setTypeRandomElement() that is modified in order to return multiple entries, using dictGetRandomKeys() and intsetRandomMembers().
      Added tests for SPOP with <count>: unit/type/set, unit/scripting, integration/aof
      --
      Cleaned up code a bit to match with required Redis coding style
      28802887
  12. 11 Dec, 2014 2 commits
  13. 03 Dec, 2014 1 commit
    • antirez's avatar
      Network bandwidth tracking + refactoring. · 1b732c09
      antirez authored
      Track bandwidth used by clients and replication (but diskless
      replication is not tracked since the actual transfer happens in the
      child process).
      
      This includes a refactoring that makes tracking new instantaneous
      metrics simpler.
      1b732c09
  14. 02 Dec, 2014 1 commit
  15. 11 Nov, 2014 2 commits
    • antirez's avatar
      Diskless SYNC: fix RDB EOF detection. · bb7fea0d
      antirez authored
      RDB EOF detection was relying on the final part of the RDB transfer to
      be a magic 40 bytes EOF marker. However as the slave is put online
      immediately, and because of sockets timeouts, the replication stream is
      actually contiguous with the RDB file.
      
      This means that to detect the EOF correctly we should either:
      
      1) Scan all the stream searching for the mark. Sucks CPU-wise.
      2) Start to send the replication stream only after an acknowledge.
      3) Implement a proper chunked encoding.
      
      For now solution "2" was picked, so the master does not start to send
      ASAP the stream of commands in the case of diskless replication. We wait
      for the first REPLCONF ACK command from the slave, that certifies us
      that the slave correctly loaded the RDB file and is ready to get more
      data.
      bb7fea0d
    • Pierre-Yves Ritschard's avatar
      Support daemon supervision by upstart or systemd · bc1a3b96
      Pierre-Yves Ritschard authored
      Both upstart and systemd provide a way for daemons to
      be supervised, as well as a mechanism for them to
      signal their readyness status.
      
      This patch provides compatibility with this functionality while
      not interfering with other methods.
      
      With this, it will be possible to use `expect stop` with upstart
      and `Type=notify` with systemd.
      
      A more detailed explanation of the mechanism can be found here:
      http://spootnik.org/entries/2014/11/09_pid-tracking-in-modern-init-systems.html
      bc1a3b96
  16. 27 Oct, 2014 2 commits
  17. 16 Oct, 2014 3 commits
  18. 14 Oct, 2014 2 commits
  19. 08 Oct, 2014 1 commit
    • antirez's avatar
      Define different types of RDB childs. · 2df8341c
      antirez authored
      We need to remember what is the saving strategy of the current RDB child
      process, since the configuration may be modified at runtime via CONFIG
      SET and still we'll need to understand, when the child exists, what to
      do and for what goal the process was initiated: to create an RDB file
      on disk or to write stuff directly to slave's sockets.
      2df8341c
  20. 29 Sep, 2014 1 commit
  21. 17 Sep, 2014 1 commit
  22. 08 Sep, 2014 1 commit
  23. 13 Aug, 2014 1 commit
  24. 12 Aug, 2014 1 commit
  25. 08 Aug, 2014 1 commit
  26. 07 Aug, 2014 2 commits
  27. 16 Jul, 2014 1 commit
    • antirez's avatar
      PubSub clients refactoring and new PUBSUB flag. · 59cf0824
      antirez authored
      The code tested many times if a client had active Pub/Sub subscriptions
      by checking the length of a list and dictionary where the patterns and
      channels are stored. This was substituted with a client flag called
      REDIS_PUBSUB that is simpler to test for. Moreover in order to manage
      this flag some code was refactored.
      
      This commit is believed to have no effects in the behavior of the
      server.
      59cf0824
  28. 08 Jul, 2014 1 commit
  29. 04 Jul, 2014 1 commit
  30. 02 Jul, 2014 1 commit