1. 11 Mar, 2014 6 commits
  2. 05 Mar, 2014 8 commits
    • antirez's avatar
      4d5ba596
    • antirez's avatar
      Sentinel: more aggressive failover start desynchronization. · 313f8831
      antirez authored
      Sentinel needs to avoid split brain conditions due to multiple sentinels
      trying to get voted at the exact same time.
      
      So far some desynchronization was provided by fluctuating server.hz,
      that is the frequency of the timer function call. However the
      desynchonization provided in this way was not enough when using many
      Sentinel instances, especially when a large quorum value is used in
      order to force a greater degree of agreement (more than N/2+1).
      
      It was verified that it was likely to trigger a split brain
      condition, forcing the system to try again after a timeout.
      Usually the system will succeed after a few retries, but this is not
      optimal.
      
      This commit desynchronizes instances in a more effective way to make it
      likely that the first attempt will be successful.
      313f8831
    • antirez's avatar
      5ee23944
    • antirez's avatar
      d2e16801
    • antirez's avatar
      Document why we update peak memory in INFO. · 1d9eb47f
      antirez authored
      1d9eb47f
    • antirez's avatar
      Fix configEpoch assignment when a cluster slot gets "closed". · e4833ed8
      antirez authored
      This is still code to rework in order to use agreement to obtain a new
      configEpoch when a slot is migrated, however this commit handles the
      special case that happens when the nodes are just started and everybody
      has a configEpoch of 0. In this special condition to have the maximum
      configEpoch is not enough as the special epoch 0 is not unique (all the
      others are).
      
      This does not fixes the intrinsic race condition of a failover happening
      while we are resharding, that will be addressed later.
      e4833ed8
    • Matt Stancliff's avatar
      Force INFO used_memory_peak to match peak memory · 7c092b67
      Matt Stancliff authored
      used_memory_peak only updates in serverCron every server.hz,
      but Redis can use more memory and a user can request memory
      INFO before used_memory_peak gets updated in the next
      cron run.
      
      This patch updates used_memory_peak to the current
      memory usage if the current memory usage is higher
      than the recorded used_memory_peak value.
      
      (And it only calls zmalloc_used_memory() once instead of
      twice as it was doing before.)
      7c092b67
    • michael-grunder's avatar
      Improved bigkeys with progress, pipelining and summary · 23addbb5
      michael-grunder authored
      This commit reworks the redis-cli --bigkeys command to provide more
      information about our progress as well as output summary information
      when we're done.
      
       - We now show an approximate percentage completion as we go
       - Hiredis pipelining is used for TYPE and SIZE retreival
       - A summary of keyspace distribution and overall breakout at the end
      23addbb5
  3. 28 Feb, 2014 1 commit
  4. 27 Feb, 2014 5 commits
    • antirez's avatar
      warnigns -> warnings in redisBitpos(). · 9104f1e6
      antirez authored
      9104f1e6
    • antirez's avatar
      More consistent BITPOS behavior with bit=0 and ranges. · eacc0951
      antirez authored
      With the new behavior it is possible to specify just the start in the
      range (the end will be assumed to be the first byte), or it is possible
      to specify both start and end.
      
      This is useful to change the behavior of the command when looking for
      zeros inside a string.
      
      1) If the user specifies both start and end, and no 0 is found inside
         the range, the command returns -1.
      
      2) If instead no range is specified, or just the start is given, even
         if in the actual string no 0 bit is found, the command returns the
         first bit on the right after the end of the string.
      
      So for example if the string stored at key foo is "\xff\xff":
      
          BITPOS foo (returns 16)
          BITPOS foo 0 -1 (returns -1)
          BITPOS foo 0 (returns 16)
      
      The idea is that when no end is given the user is just looking for the
      first bit that is zero and can be set to 1 with SETBIT, as it is
      "available". Instead when a specific range is given, we just look for a
      zero within the boundaries of the range.
      eacc0951
    • antirez's avatar
      Initial implementation of BITPOS. · 1f8005ca
      antirez authored
      It appears to work but more stress testing, and both unit tests and
      fuzzy testing, is needed in order to ensure the implementation is sane.
      1f8005ca
    • antirez's avatar
      Fix misaligned word access in redisPopcount(). · 24265edb
      antirez authored
      24265edb
    • Matt Stancliff's avatar
      7e274194
  5. 25 Feb, 2014 13 commits
  6. 20 Feb, 2014 1 commit
  7. 18 Feb, 2014 2 commits
    • antirez's avatar
      Sentinel: SENTINEL_SLAVE_RECONF_RETRY_PERIOD -> RECONF_TIMEOUT · 6e4662e4
      antirez authored
      Rename define to match the new meaning.
      6e4662e4
    • antirez's avatar
      Sentinel: fix slave promotion timeout. · bd31fcf1
      antirez authored
      If we can't reconfigure a slave in time during failover, go forward as
      anyway the slave will be fixed by Sentinels in the future, once they
      detect it is misconfigured.
      
      Otherwise a failover in progress may never terminate if for some reason
      the slave is uncapable to sync with the master while at the same time
      it is not disconnected.
      bd31fcf1
  8. 17 Feb, 2014 2 commits
    • antirez's avatar
      Get absoulte config file path before processig 'dir'. · 58b6dd9b
      antirez authored
      The code tried to obtain the configuration file absolute path after
      processing the configuration file. However if config file was a relative
      path and a "dir" statement was processed reading the config, the absolute
      path obtained was wrong.
      
      With this fix the absolute path is obtained before processing the
      configuration while the server is still in the original directory where
      it was executed.
      58b6dd9b
    • antirez's avatar
      Sentinel: better specify startup errors due to config file. · c36a5dce
      antirez authored
      Now it logs the file name if it is not accessible. Also there is a
      different error for the missing config file case, and for the non
      writable file case.
      c36a5dce
  9. 13 Feb, 2014 2 commits
    • antirez's avatar
      Update cached time in rdbLoad() callback. · 3c1672da
      antirez authored
      server.unixtime and server.mstime are cached less precise timestamps
      that we use every time we don't need an accurate time representation and
      a syscall would be too slow for the number of calls we require.
      
      Such an example is the initialization and update process of the last
      interaction time with the client, that is used for timeouts.
      
      However rdbLoad() can take some time to load the DB, but at the same
      time it did not updated the time during DB loading. This resulted in the
      bug described in issue #1535, where in the replication process the slave
      loads the DB, creates the redisClient representation of its master, but
      the timestamp is so old that the master, under certain conditions, is
      sensed as already "timed out".
      
      Thanks to @yoav-steinberg and Redis Labs Inc for the bug report and
      analysis.
      3c1672da
    • antirez's avatar
      Log when CONFIG REWRITE goes bad. · 116617c5
      antirez authored
      116617c5