1. 21 Mar, 2014 7 commits
    • antirez's avatar
      Set LRU parameters via REDIS_LRU_BITS define. · ff8c8187
      antirez authored
      ff8c8187
    • antirez's avatar
      Unify stats reset for CONFIG RESETSTAT / initServer(). · e3b71a1c
      antirez authored
      Now CONFIG RESETSTAT makes sure to reset all the fields, and in the
      future it will be simpler to avoid missing new fields.
      e3b71a1c
    • antirez's avatar
      Sentinel: sentinelRefreshInstanceInfo() minor refactoring. · 0937377a
      antirez authored
      Test sentinel.tilt condition on top and return if it is true.
      This allows to remove the check for the tilt condition in the remaining
      code paths of the function.
      0937377a
    • antirez's avatar
    • antirez's avatar
      Sentinel: down-after-milliseconds is not master-specific. · ffa8f479
      antirez authored
      addReplySentinelRedisInstance() modified so that this field is displayed
      for all the kind of instances: Sentinels, Masters, Slaves.
      ffa8f479
    • antirez's avatar
      Sentinel failure detection implementation improved. · 42091a79
      antirez authored
      Failure detection in Sentinel is ping-pong based. It used to work by
      remembering the last time a valid PONG reply was received, and checking
      if the reception time was too old compared to the current current time.
      
      PINGs were sent at a fixed interval of 1 second.
      
      This works in a decent way, but does not scale well when we want to set
      very small values of "down-after-milliseconds" (this is the node
      timeout basically).
      
      This commit reiplements the failure detection making a number of
      changes. Some changes are inspired to Redis Cluster failure detection
      code:
      
      * A new last_ping_time field is added in representation of instances.
        If non zero, we have an active ping that was sent at the specified
        time. When a valid reply to ping is received, the field is zeroed
        again.
      * last_ping_time is not reset when we reconnect the link or send a new
        ping, so from our point of view it represents the time we started
        waiting for the instance to reply to our pings without receiving a
        reply.
      * last_ping_time is now used in order to check if the instance is
        timed out. This means that we can have a node timeout of 100
        milliseconds and yet the system will work well since the new check is
        not bound to the period used to send pings.
      * Pings are now sent every second, or often if the value of
        down-after-milliseconds is less than one second. With a lower limit of
        10 HZ ping frequency.
      * Link reconnection code was improved. This is used in order to try to
        reconnect the link when we are at 50% of the node timeout without a
        valid reply received yet. However the old code triggered unnecessary
        reconnections when the node timeout was very small. Now that should be
        ok.
      
      The new code passes the tests but more testing is needed and more unit
      tests stressing the failure detector, so currently this is merged only
      in the unstable branch.
      42091a79
    • antirez's avatar
      Sentinel: use CLIENT SETNAME when connecting to Redis. · 38241c4b
      antirez authored
      This makes debugging / monitoring of Sentinels simpler since you can
      identify sentinels in CLIENT LIST output of Redis instances.
      38241c4b
  2. 14 Mar, 2014 4 commits
    • Matt Stancliff's avatar
      Fix segfault from accessing array out of bounds · 9de07558
      Matt Stancliff authored
      argc == 2; argv[2] == crash
      9de07558
    • antirez's avatar
      Sentinel: be safe under crash-recovery assumptions. · a31a0b43
      antirez authored
      Sentinel's main safety argument is that there are no two configurations
      for the same master with the same version (configuration epoch).
      
      For this to be true Sentinels require to be authorized by a majority.
      Additionally Sentinels require to do two important things:
      
      * Never vote again for the same epoch.
      * Never exchange an old vote for a fresh one.
      
      The first prerequisite, in a crash-recovery system model, requires to
      persist the master->leader_epoch on durable storage before to reply to
      messages. This was not the case.
      
      We also make sure to persist the current epoch in order to never reply
      to stale votes requests from other Sentinels, after a recovery.
      
      The configuration is persisted by making use of fsync(), this is
      considered in the context of this code a good enough guarantee that
      after a restart our durable state is restored, however this may not
      always be the case depending on the kind of hardware and operating
      system used.
      a31a0b43
    • antirez's avatar
      Sentinel: fake PUBLISH command to receive HELLO messages. · 6b0e36ff
      antirez authored
      Now the way HELLO messages are received is unified.
      Now it is no longer needed for Sentinels to converge to the higher
      configuration for a master to be able to chat via some Redis instance,
      the are able to directly exchanges configurations.
      
      Note that this commit does not include the (trivial) change needed to
      send HELLO messages to Sentinel instances as well, since for an error I
      committed the change in the previous commit that refactored hello
      messages processing into a separated function.
      6b0e36ff
    • antirez's avatar
  3. 13 Mar, 2014 1 commit
  4. 11 Mar, 2014 4 commits
  5. 10 Mar, 2014 3 commits
    • antirez's avatar
      DEBUG ERROR implemented. · eb9e1526
      antirez authored
      The new "error" subcommand of the DEBUG command can reply with an user
      selected error, specified as its sole argument:
      
          DEBUG ERROR "LOADING please wait..."
      
      The error is generated just prefixing the command argument with a "-"
      character, and replacing newlines with spaces (since error replies can't
      include newlines).
      
      The goal of the command is to help in Client libraries unit tests by
      making simple to simulate a command call triggering a given error.
      eb9e1526
    • Matt Stancliff's avatar
      Fix return value check for anetTcpAccept · a6970570
      Matt Stancliff authored
      anetTcpAccept returns ANET_ERR, not AE_ERR.
      
      This isn't a physical error since both ANET_ERR
      and AE_ERR are -1, but better to be consistent.
      a6970570
    • antirez's avatar
  6. 05 Mar, 2014 8 commits
    • antirez's avatar
      Redis 2.8.7. · 464fef9b
      antirez authored
      464fef9b
    • antirez's avatar
      aab16ead
    • antirez's avatar
      Document why we update peak memory in INFO. · 55b8f6ec
      antirez authored
      55b8f6ec
    • Matt Stancliff's avatar
      Force INFO used_memory_peak to match peak memory · 647a2614
      Matt Stancliff authored
      used_memory_peak only updates in serverCron every server.hz,
      but Redis can use more memory and a user can request memory
      INFO before used_memory_peak gets updated in the next
      cron run.
      
      This patch updates used_memory_peak to the current
      memory usage if the current memory usage is higher
      than the recorded used_memory_peak value.
      
      (And it only calls zmalloc_used_memory() once instead of
      twice as it was doing before.)
      647a2614
    • antirez's avatar
      Sentinel test: Makefile target added. · 9c66cd91
      antirez authored
      9c66cd91
    • michael-grunder's avatar
      Improved bigkeys with progress, pipelining and summary · 69917929
      michael-grunder authored
      This commit reworks the redis-cli --bigkeys command to provide more
      information about our progress as well as output summary information
      when we're done.
      
       - We now show an approximate percentage completion as we go
       - Hiredis pipelining is used for TYPE and SIZE retreival
       - A summary of keyspace distribution and overall breakout at the end
      69917929
    • antirez's avatar
      Sentinel: more aggressive failover start desynchronization. · 1606978a
      antirez authored
      Sentinel needs to avoid split brain conditions due to multiple sentinels
      trying to get voted at the exact same time.
      
      So far some desynchronization was provided by fluctuating server.hz,
      that is the frequency of the timer function call. However the
      desynchonization provided in this way was not enough when using many
      Sentinel instances, especially when a large quorum value is used in
      order to force a greater degree of agreement (more than N/2+1).
      
      It was verified that it was likely to trigger a split brain
      condition, forcing the system to try again after a timeout.
      Usually the system will succeed after a few retries, but this is not
      optimal.
      
      This commit desynchronizes instances in a more effective way to make it
      likely that the first attempt will be successful.
      1606978a
    • antirez's avatar
      62001919
  7. 28 Feb, 2014 1 commit
  8. 27 Feb, 2014 8 commits
    • antirez's avatar
      warnigns -> warnings in redisBitpos(). · 1892b562
      antirez authored
      1892b562
    • antirez's avatar
      More consistent BITPOS behavior with bit=0 and ranges. · 2c8036f7
      antirez authored
      With the new behavior it is possible to specify just the start in the
      range (the end will be assumed to be the first byte), or it is possible
      to specify both start and end.
      
      This is useful to change the behavior of the command when looking for
      zeros inside a string.
      
      1) If the user specifies both start and end, and no 0 is found inside
         the range, the command returns -1.
      
      2) If instead no range is specified, or just the start is given, even
         if in the actual string no 0 bit is found, the command returns the
         first bit on the right after the end of the string.
      
      So for example if the string stored at key foo is "\xff\xff":
      
          BITPOS foo (returns 16)
          BITPOS foo 0 -1 (returns -1)
          BITPOS foo 0 (returns 16)
      
      The idea is that when no end is given the user is just looking for the
      first bit that is zero and can be set to 1 with SETBIT, as it is
      "available". Instead when a specific range is given, we just look for a
      zero within the boundaries of the range.
      2c8036f7
    • antirez's avatar
      Initial implementation of BITPOS. · 3294f74f
      antirez authored
      It appears to work but more stress testing, and both unit tests and
      fuzzy testing, is needed in order to ensure the implementation is sane.
      3294f74f
    • antirez's avatar
      Fix misaligned word access in redisPopcount(). · 30a92b6c
      antirez authored
      30a92b6c
    • antirez's avatar
      warnigns -> warnings in redisBitpos(). · c1cc28f2
      antirez authored
      c1cc28f2
    • antirez's avatar
      More consistent BITPOS behavior with bit=0 and ranges. · d79f9ebd
      antirez authored
      With the new behavior it is possible to specify just the start in the
      range (the end will be assumed to be the first byte), or it is possible
      to specify both start and end.
      
      This is useful to change the behavior of the command when looking for
      zeros inside a string.
      
      1) If the user specifies both start and end, and no 0 is found inside
         the range, the command returns -1.
      
      2) If instead no range is specified, or just the start is given, even
         if in the actual string no 0 bit is found, the command returns the
         first bit on the right after the end of the string.
      
      So for example if the string stored at key foo is "\xff\xff":
      
          BITPOS foo (returns 16)
          BITPOS foo 0 -1 (returns -1)
          BITPOS foo 0 (returns 16)
      
      The idea is that when no end is given the user is just looking for the
      first bit that is zero and can be set to 1 with SETBIT, as it is
      "available". Instead when a specific range is given, we just look for a
      zero within the boundaries of the range.
      d79f9ebd
    • antirez's avatar
      Initial implementation of BITPOS. · 25e2791e
      antirez authored
      It appears to work but more stress testing, and both unit tests and
      fuzzy testing, is needed in order to ensure the implementation is sane.
      25e2791e
    • antirez's avatar
      Fix misaligned word access in redisPopcount(). · 580ed076
      antirez authored
      580ed076
  9. 25 Feb, 2014 4 commits