only promote node to voting when its nonvoting has been applied (#12)
before we were able to promote a "ready" but not applied nonvoting node to a voting state, which means it would change the calculation as could vote for itself to be added. * fix tests that check for has_sufficient_logs because of a fix put in to not allow a node to be added until its "addition" as a non voter was comitted, that broke existing tests where that flag wasn't being set and testing that the nodes could be promoted * add a test that has_sufficient_logs will fail if addition not committed yet code before would add a node as a voter (via has_sufficient_logs) even if the initial non voter addition wasn't committed the test for this in the code actually tested after setting addition_committed. add a test that does the same without that flag being set and expects that has_sufficient_logs will not be set
Please register or sign in to comment