1. 22 Sep, 2022 1 commit
  2. 20 Sep, 2022 1 commit
  3. 19 Sep, 2022 4 commits
    • Ozan Tezcan's avatar
      Documentation fixes (#142) · 6ca56090
      Ozan Tezcan authored
      
      
      Documentation fixes
      Co-authored-by: default avatarHanna Fadida <hanna.fadida@redislabs.com>
      6ca56090
    • Ozan Tezcan's avatar
      Documentation (#140) · 5d42a923
      Ozan Tezcan authored
      Documentation
      5d42a923
    • Ozan Tezcan's avatar
      Handle unnecessary snapshots better (#143) · 85ae16e0
      Ozan Tezcan authored
      If a node receives a snapshot with snapshot_last_idx, it checks if 
      it already has the snapshot and informs leader accordingly.
      
      The problem is the receiver node may not have a snapshot but log 
      entries more than snapshot_last_idx:
      
      e.g
      Leader: snapshot_last_idx : 50
      Follower: snapshot_last_idx:0, last log entry index: 100
      
      If the leader tries to send snapshot to the follower 
      (with snapshot last index:50), currently, follower accepts 
      the snapshot. As follower already has entries upto index 100, snapshot
      is unnecessary. After delivery is complete, to load the snapshot, 
      follower will call raft_begin_load_snapshot(). This function realizes
      the snapshot was unnecessary and it fails. It is harmless but snapshot
      delivery was unnecessary.
      
      This PR prevents this issue earlier by checking last log index instead
       of snapshot last index.
      
      Also, added more virtraft tests with auto-flush on. 
      (This is a different pattern, it might help with detecting these issues)
      85ae16e0
    • Ozan Tezcan's avatar
      Move internal functions to the private API (#141) · c76eac81
      Ozan Tezcan authored
      Moved internal functions to raft_internal.h
      
      Still, application can include raft_private.h use internal
      functions (not suggested).
      c76eac81
  4. 12 Sep, 2022 3 commits
    • Ozan Tezcan's avatar
      Handle response error cases gracefully (#137) · 8db9930c
      Ozan Tezcan authored
      A node can receive responses from followers who are not
      aware of they have been removed from the cluster configuration.
      In this case, recv_ family functions can be called without 
      a node structure. We should ignore these messages.
      
      We should also ignore snapshot and appendentries responses
      if we are not leader anymore. Returning an error code for 
      this case does not make sense because application cannot 
      do anything but ignore the error code. 
      
      This PR changes return value to zero for these cases. 
      8db9930c
    • Ozan Tezcan's avatar
      Add raft_get_error_str() (#134) · 703e70c2
      Ozan Tezcan authored
      Added a helper function to get string representation of an error code.
      703e70c2
    • Ozan Tezcan's avatar
      Refactor callback documentation (#139) · 8857bcdd
      Ozan Tezcan authored
      Refactor callback comments.
      
      - Regroup related callbacks.
      - Move optional callbacks to the bottom and indicate "(optional)".
      8857bcdd
  5. 05 Sep, 2022 1 commit
  6. 04 Sep, 2022 1 commit
  7. 30 Aug, 2022 1 commit
    • Ozan Tezcan's avatar
      Refactor debug logging (#127) · e79d3b6a
      Ozan Tezcan authored
      Refactor debug logging and change log callback
      
      e.g:
      19 --> 13, sent snapshot_resp id:27712, t:24, s:1, o:4096, lc:0
      14 --> 17, sent requestvote_req pv:1, t:25, ci:14, lli:6848, llt:23
      14 <-- 17, recv requestvote_resp pv:1, t:25, rt:24, vg:0
      
      Breaking changes: 
      
      raft_log_f() callback will not pass node_id_t anymore.
      Sender and receiver will be part of the log line as you can see above.
      e79d3b6a
  8. 29 Aug, 2022 3 commits
    • Ozan Tezcan's avatar
      Simplify entry removal (#130) · c0270e61
      Ozan Tezcan authored
      Simplied pop callback.
      
      Previously, libraft was passing a callback(raft_entry_notify_f) to the pop callback.
      The application was supposed to call that callback for each removed entry.
      
      Libraft can loop over the entries and call the required functions itself.
      So, we can delete raft_entry_notify_f from the pop callback just to
      simplify API.
      
      In addition to that, this PR removes raft_pop_entry() function which doesn't have
      a use-case, as far as I can see.
      We can use raft_delete_entry_from_idx(me, raft_get_current_idx()) instead if required.
      c0270e61
    • Ozan Tezcan's avatar
      Add raft_get_last_applied_term() (#131) · 2279a960
      Ozan Tezcan authored
      Add raft_get_last_applied_term()
      2279a960
    • Ozan Tezcan's avatar
      Fix style (#128) · 21844ec6
      Ozan Tezcan authored
      Fix style issues in raft_log.c raft_node.c and raft_server_properties.c
      21844ec6
  9. 28 Aug, 2022 1 commit
  10. 25 Aug, 2022 2 commits
    • Ozan Tezcan's avatar
      Fix memory leak in raft_restore_log() (#126) · f1ab5203
      Ozan Tezcan authored
      f1ab5203
    • Ozan Tezcan's avatar
      Add support to rebuild configuration after a restart (#125) · 9c09a6cc
      Ozan Tezcan authored
      Configuration changes are special in Raft. They take effect 
      whenever the related log entries are appended. On a restart, 
      we should go over the log entries and rebuild the configuration.
      
      Adding raft_restore_log() function for this purpose.
      
      Overall, on a restart, application should do:
      
      Load the snapshot and call raft_restore_snapshot()
      Load the log entries and call raft_restore_log()
      Read the metadata file and call raft_restore_metadata().
      9c09a6cc
  11. 23 Aug, 2022 3 commits
  12. 22 Aug, 2022 2 commits
    • Ozan Tezcan's avatar
      Fix return types (#122) · e8791a27
      Ozan Tezcan authored
      Use typedef instead of the actual type
      e8791a27
    • Ozan Tezcan's avatar
      Improve snapshot support (#121) · 7d66a156
      Ozan Tezcan authored
      - raft_load_snapshot_f(): Changed order of arguments term and index
      to be inline with raft_begin_load_snapshot().
      
      - Refactored raft_begin_load_snapshot(). Now, inside this function, 
      current server's node flags are cleared. Previously, application had to
      take care of it. e.g Application had to clear inactive flag on a snapshot.
      
      - Added raft_restore_snapshot() to let libraft know that application has
      loaded a snapshot.
      7d66a156
  13. 18 Aug, 2022 1 commit
  14. 16 Aug, 2022 3 commits
  15. 08 Aug, 2022 1 commit
  16. 21 Jul, 2022 2 commits
  17. 07 Jul, 2022 2 commits
  18. 05 Jul, 2022 1 commit
    • Ozan Tezcan's avatar
      Do not execute operations in periodic when auto_flush is off (#109) · 03e2f294
      Ozan Tezcan authored
      Do not execute operations in periodic when auto_flush is off 
      
      Introduced auto_flush config in #81. If auto_flush is off, application is supposed to call raft_flush() manually. This function increments commit index, applies entries and sends appendentries requests.
      
      Currently, we execute operations in raft_periodic() and raft_flush() both. When auto_flush is off, it makes sense to leave execution to raft_flush() to do it in a single place.
      03e2f294
  19. 30 Jun, 2022 1 commit
  20. 19 Jun, 2022 1 commit
  21. 19 May, 2022 1 commit
  22. 15 May, 2022 1 commit
  23. 02 May, 2022 1 commit
  24. 26 Apr, 2022 1 commit
  25. 25 Apr, 2022 1 commit