- 13 Jun, 2018 2 commits
- 
- 
Willem Thiart authoredThis fixes the virtraft checks. 
- 
Yossi Gottlieb authoredAE responses from a non-voting node can be ignored during a voting change, causing has_sufficient_logs for this node to never fire in the future. 
 
- 
- 11 Jun, 2018 5 commits
- 
- 
Yossi Gottlieb authoredThis behavior is described in the original Raft paper and is required to prevent removed nodes from disrupting the cluster. This causes other problems though, as a split node may trigger election which is rejected but leaves it with a future term. The generally accepted solution for this appears to be the use of PreVote RPC to avoid election that can never succeed. 
- 
Willem Thiart authored
- 
Willem Thiart authoredThis is an optional callback. This is useful for the user to know when a node has been added/removed, so that something like raft_node_set_udata can be set properly. 
- 
Willem Thiart authored
- 
Willem Thiart authoredraft_node_set_voting_committed raft_node_set_addition_committed raft_voting_change_is_in_progress 
 
- 
- 08 Jun, 2018 1 commit
- 
- 
Jiale Zhi authored
 
- 
- 07 Jun, 2018 2 commits
- 
- 
Willem Thiart authoredThe RAFT_LOGTYPE_SNAPSHOT was a bad design choice. It's better to not have this marker entry so that users don't have to check for the log entry type in the callbacks. Also, loading a snapshot correctly created this marker entry, but the compaction side did not. It's better to remove this log type than to fix this asymmetry. Fixes the following edge cases: - Server crashes if the last snapshot index is N and a appendentries message pops entries all the way back to index N. - Server sends an appendentries message with an invalid prev_log_idx and prev_log_term, causing the peer to crash. 
- 
Yossi Gottlieb authored* Fix off-by-one in apply_log idx. * Fix log_get_from_idx() off by one error. 
 
- 
- 23 May, 2018 2 commits
- 
- 
Yossi Gottlieb authored
- 
Yossi Gottlieb authored
 
- 
- 17 May, 2018 4 commits
- 
- 
Li Wei authoredAn AE request's prevLogTerm and entries should never conflict with the follower's committed entries, according to the Raft protocol. If this happens, we should print a warning and inform callers to shut down. Signed-off-by:Li Wei <wei.g.li@intel.com> 
- 
Li Wei authoredSince mod() has a short name and is only in raft_log.c, it should be static. Signed-off-by:Li Wei <wei.g.li@intel.com> 
- 
Willem Thiart authored
- 
Willem Thiart authoredThis fixes the virtraft checks. 
 
- 
- 16 May, 2018 7 commits
- 
- 
Willem Thiart authored
- 
skypexu authoredFix raft_begin_load_snapshot last_included_term handling 
- 
Yossi Gottlieb authored
- 
Willem Thiart authored
- 
Willem Thiart authored
- 
Yossi Gottlieb authoredThis fails the fuzzer tests. 
- 
Yossi Gottlieb authoredThis is a breaking change. 
 
- 
- 09 Jan, 2018 2 commits
- 
- 
Willem Thiart authored
- 
Willem Thiart authored
 
- 
- 08 Jan, 2018 4 commits
- 
- 
Willem Thiart authored
- 
Willem Thiart authored
- 
Willem Thiart authored
- 
Willem Thiart authored
 
- 
- 29 Dec, 2017 2 commits
- 
- 
Willem Thiart authored
- 
Willem Thiart authoredThe raft_log API is now being fuzzed tested. This change fixes all of the bugs detected by the fuzzer so far. 
 
- 
- 21 Nov, 2017 9 commits
- 
- 
Willem Thiart authored
- 
Li Wei authoredMove the declaration of raft_become_follower() from raft_private.h to raft.h, so that users may voluntarily give up leadership. Signed-off-by:Li Wei <wei.g.li@intel.com> 
- 
Li Wei authoredUser storage callbacks may return negative errors smaller than RAFT_ERR_LAST. These will be returned all the way to the API methods, which report the errors back to users, so that appropriate handlings may be performed. Signed-off-by:Li Wei <wei.g.li@intel.com> 
- 
Li Wei authoredIf an AE request's previous entry matches the follower's, then the follower doesn't need to truncate its log at prev_log_idx. When the follower checks if the other entries in the AE request are consistent with its local ones, it already takes care of truncating at any inconsistency. If any later entries not covered by this AE request are inconsistent, future AE requests shall truncate them. Signed-off-by:Li Wei <wei.g.li@intel.com> 
- 
Li Wei authoredIf raft_become_candidate() assigns a negative value e (i.e., -election_timeout < e < 0) to timeout_elapsed, and if this replica successfully becomes the leader, then this leader won't send heartbeats for request_timeout - e milliseconds. This may be longer than election_timeout and cause an unnecessary leadership change. This patch zeroes timeout_elapsed in raft_become_leader(), randomizes election timeouts in [election_timeout, 2 * election_timeout), and fixes raft_recv_appendentries() to avoid zeroing timeout_elapsed if the AE request has an older term. Signed-off-by:Li Wei <wei.g.li@intel.com> 
- 
Li Wei authoredWhen a leader learns of a newer term and steps down, it should discard current_leader. Otherwise, a client request may be rejected with RAFT_ERR_NOT_LEADER and a hint pointing to this replica itself! For simplicity, this patche follows the Raft paper to discard current_leader whenever current_term changes. And, when receiving an AE with an up-to-date term, a server always updates current_leader, as this information is absolute, even if the previous entry doesn't match. This patch also fixes a test that has previously been failing due to incorrect node IDs. Signed-off-by:Li Wei <wei.g.li@intel.com> 
- 
Li Wei authoredlog_offer and log_poll should get log entry index rather than internal array index. That would match the callback comment in raft.h and would also match the log_pop case. Signed-off-by:Li Wei <wei.g.li@intel.com> 
- 
Li Wei authoredRemind users' persist_term implementations to persist currentTerm and nil votedFor atomically. Signed-off-by:Li Wei <wei.g.li@intel.com> 
 
-