1. 27 Jul, 2021 1 commit
    • Shaya Potter's avatar
      match up raft_get_last_log_term() to should_grant_vote() (#14) · fab583d6
      Shaya Potter authored
      raft_get_last_log_term() is used for filling in vote requests, except it didn't match 100% with the logic in should_grant_vote
      
      * update test to prove that change works as needed
      
      previous test tested when we don't snapshot everything, but code was broken when we did.
      modified test tested only when we snapshot everything, now we do both in sequence.
      
      * use raft_get_last_log_term in __should_grant_vote()
      
      also modify __should_grant_vote to take a raft_server_t instead of raft_server_privat_t so its not constantly casting it to void.
      fab583d6
  2. 26 Jul, 2021 1 commit
    • Shaya Potter's avatar
      only promote node to voting when its nonvoting has been applied (#12) · 600cf4fe
      Shaya Potter authored
      before we were able to promote a "ready" but not applied nonvoting node to a voting state, which means it would change the calculation as could vote for itself to be added.
      
      * fix tests that check for has_sufficient_logs
      
      because of a fix put in to not allow a node to be added until its "addition" as a non voter was comitted, that broke existing tests where that flag wasn't being set and testing that the nodes could be promoted
      
      * add a test that has_sufficient_logs will fail if addition not committed yet
      
      code before would add a node as a voter (via has_sufficient_logs) even if the initial non voter addition wasn't committed
      
      the test for this in the code actually tested after setting addition_committed.  add a test that does the same without that flag being set and expects that has_sufficient_logs will not be set
      600cf4fe
  3. 19 Jul, 2021 2 commits
  4. 23 May, 2021 1 commit
  5. 11 May, 2021 1 commit
    • Shaya Potter's avatar
      Fix quorum_msg_id assert (#3) · 93186886
      Shaya Potter authored
      Before this commit, active and voting flags were ignored resulting with a result that does not agree with `raft_get_num_voting_nodes()` and an assertion.
      
      This could be seen when a leader node gets removed while a read operation is in progress.
      93186886
  6. 29 May, 2020 1 commit
  7. 27 May, 2020 1 commit
  8. 26 May, 2020 1 commit
  9. 24 May, 2020 1 commit
  10. 16 Apr, 2020 1 commit
  11. 23 Mar, 2020 2 commits
    • Yossi Gottlieb's avatar
      Fix issue with AE not delivered to removed nodes. · 02fda63f
      Yossi Gottlieb authored
      During joint consensus, we need to deliver entries to demoted and
      removed nodes so they can gracefully shut down.
      
      This also fixes an issue with raft_send_appendentries_all() which
      aborted on first delivery error, creating artificial cluster partitions.
      This problem is further aggravated when attempting to deliver to
      inactive nodes.
      02fda63f
    • Yossi Gottlieb's avatar
      Revert commits c3064082 and da936a95. · 2c105362
      Yossi Gottlieb authored
      Turns out documentation is not up to date regarding the process of node
      removal, and it the current implementation assumes a two-phase process
      is always required (i.e. DEMOTE followed by REMOVE).
      2c105362
  12. 12 Mar, 2020 2 commits
    • Yossi Gottlieb's avatar
      Add RAFT_LOGTYPE_NO_OP. · 5d7915f3
      Yossi Gottlieb authored
      The no-op entry gets committed as soon as a new leader is elected, in
      order to establish the commit index and prevent stale reads.
      5d7915f3
    • Yossi Gottlieb's avatar
      Fix virtraft membership tests. · c3064082
      Yossi Gottlieb authored
      This fixes an issue with virtraft2 which was not able to perform
      REMOVE_NODE when DEMOTE_NODE was applied. The previous fix of directly
      removing nodes was not aligned with how virtraft2 manages nodes.
      c3064082
  13. 10 Mar, 2020 4 commits
  14. 31 Dec, 2018 1 commit
  15. 19 Dec, 2018 2 commits
  16. 18 Dec, 2018 1 commit
  17. 13 Dec, 2018 1 commit
  18. 11 Dec, 2018 1 commit
  19. 09 Dec, 2018 1 commit
  20. 06 Dec, 2018 1 commit
  21. 18 Nov, 2018 1 commit
  22. 16 Oct, 2018 1 commit
    • Yossi Gottlieb's avatar
      Fix a memory leak with log_clear. · 89d793a0
      Yossi Gottlieb authored
      This is probably most common when loading a snapshot.  Currently it is
      only possibly to free allocated entry memory on log_pop and log_poll,
      but neither are called on log_reset().
      
      This is a quick and non-breaking fix.  A better but not backward
      compatible option can be to have a free function callback as part of
      the entry itself (automatically called when needed, not by log_pop or
      log_poll).  This would also make it easier to avoid redundant buffer
      allocs/copies on the app side.
      89d793a0
  23. 08 Oct, 2018 2 commits
  24. 06 Oct, 2018 3 commits
  25. 04 Oct, 2018 2 commits
  26. 27 Sep, 2018 4 commits