Unverified Commit 243593cd authored by Philippe Kueck's avatar Philippe Kueck
Browse files

fix warnings and remove unused ${tmp} variable

parent 54d61bdc
...@@ -13,16 +13,15 @@ dns_nsupdate_add() { ...@@ -13,16 +13,15 @@ dns_nsupdate_add() {
_saveaccountconf NSUPDATE_SERVER "${NSUPDATE_SERVER}" _saveaccountconf NSUPDATE_SERVER "${NSUPDATE_SERVER}"
_saveaccountconf NSUPDATE_KEY "${NSUPDATE_KEY}" _saveaccountconf NSUPDATE_KEY "${NSUPDATE_KEY}"
_info "adding ${fulldomain}. 60 in txt \"${txtvalue}\"" _info "adding ${fulldomain}. 60 in txt \"${txtvalue}\""
nsupdate -k ${NSUPDATE_KEY} <<EOF nsupdate -k "${NSUPDATE_KEY}" <<EOF
server ${NSUPDATE_SERVER} server ${NSUPDATE_SERVER}
update add ${fulldomain}. 60 in txt "${txtvalue}" update add ${fulldomain}. 60 in txt "${txtvalue}"
send send
EOF EOF
if [ $? -ne 0 ]; then if [ $? -ne 0 ]; then
_err "error updating domain, see ${tmp} for details" _err "error updating domain"
return 1 return 1
fi fi
rm -f ${tmp}
return 0 return 0
} }
...@@ -33,16 +32,15 @@ dns_nsupdate_rm() { ...@@ -33,16 +32,15 @@ dns_nsupdate_rm() {
_checkKeyFile || return 1 _checkKeyFile || return 1
[ -n "${NSUPDATE_SERVER}" ] || NSUPDATE_SERVER="localhost" [ -n "${NSUPDATE_SERVER}" ] || NSUPDATE_SERVER="localhost"
_info "removing ${fulldomain}. txt" _info "removing ${fulldomain}. txt"
nsupdate -k ${NSUPDATE_KEY} <<EOF nsupdate -k "${NSUPDATE_KEY}" <<EOF
server ${NSUPDATE_SERVER} server ${NSUPDATE_SERVER}
update delete ${fulldomain}. txt update delete ${fulldomain}. txt
send send
EOF EOF
if [ $? -ne 0 ]; then if [ $? -ne 0 ]; then
_err "error updating domain, see ${tmp} for details" _err "error updating domain"
return 1 return 1
fi fi
rm -f ${tmp}
return 0 return 0
} }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment