1. 27 Nov, 2022 1 commit
  2. 26 Nov, 2022 1 commit
    • Kiril Isakov's avatar
      Trim trailing slash in `--home` argument's value · 9f942a6b
      Kiril Isakov authored
      # What's expected
      
      Since in `acme.sh` path strings are concatenated with a hardcoded slash in between, the left operand must never end with a trailing slash for the resulting path to be valid. Otherwise, obviously, the resulting path will have two adjacent slashes in the middle and will not be valid.
      
      # What actually happens
      
      Even though I cannot tell for each of the input params, I know this for sure for the the `--home` argument's value.
      
      If I run `acme.sh` with `--home` argument's value being a path ending in a trailing slash,
      
      ```sh
      acme.sh ... --debug ... --home /some/path/ ... -d somedomainna.me ...
      ```
      
      I get the following (distinct) occurrencies of resulting invalid paths containing two adjacent slashes:
      
      ```
      [...] Using config home:/some/path/
      
      [...] DOMAIN_PATH='/some/path//somedomainna.me'
      
      [...] _CURL='curl --silent --dump-header /some/path//http.header  -L  -g '
      
      [...] The domain key is here: /some/path//somedomainna.me/somedomainna.me.key
      
      [...] _CURL='curl --silent --dump-header /some/path//http.header  -L  -g  -I  '
      
      [...] Your cert is in: /some/path//somedomainna.me/somedomainna.me.cer
      
      [...] Your cert key is in: /some/path//somedomainna.me/somedomainna.me.key
      
      [...] The intermediate CA cert is in: /some/path//somedomainna.me/ca.cer
      
      [...] And the full chain certs is there: /some/path//somedomainna.me/fullchain.cer
      
      ```
      
      # Suggested fix
      
      Trim trailing slash in `--home` argument's value from the get-go.
      9f942a6b
  3. 23 Nov, 2022 7 commits
  4. 20 Nov, 2022 1 commit
  5. 17 Nov, 2022 1 commit
  6. 07 Nov, 2022 1 commit
  7. 29 Oct, 2022 3 commits
  8. 27 Oct, 2022 2 commits
  9. 24 Oct, 2022 1 commit
  10. 16 Oct, 2022 1 commit
  11. 12 Oct, 2022 1 commit
  12. 11 Oct, 2022 1 commit
  13. 05 Oct, 2022 4 commits
  14. 04 Oct, 2022 1 commit
  15. 02 Oct, 2022 4 commits
  16. 01 Oct, 2022 2 commits
  17. 30 Sep, 2022 2 commits
  18. 29 Sep, 2022 1 commit
  19. 28 Sep, 2022 1 commit
  20. 27 Sep, 2022 1 commit
  21. 24 Sep, 2022 3 commits