1. 19 Mar, 2022 3 commits
  2. 18 Mar, 2022 2 commits
  3. 17 Mar, 2022 1 commit
  4. 19 Feb, 2022 3 commits
  5. 10 Feb, 2022 1 commit
  6. 08 Feb, 2022 1 commit
  7. 07 Feb, 2022 2 commits
  8. 20 Jan, 2022 2 commits
  9. 19 Jan, 2022 4 commits
  10. 16 Jan, 2022 1 commit
  11. 09 Jan, 2022 1 commit
  12. 06 Jan, 2022 1 commit
  13. 13 Nov, 2021 1 commit
  14. 11 Nov, 2021 1 commit
  15. 01 Nov, 2021 1 commit
  16. 30 Sep, 2021 1 commit
  17. 04 Sep, 2021 1 commit
  18. 01 Sep, 2021 2 commits
  19. 26 May, 2021 2 commits
    • Brian Hartvigsen's avatar
      shellcheck cleanup · dcb51683
      Brian Hartvigsen authored
      shellcheck sees '\\' as trying to escape the trailing quote (see
      koalaman/shellcheck#1548 ).
      dcb51683
    • Brian Hartvigsen's avatar
      Make certificate descriptions sed safe · 74a4a788
      Brian Hartvigsen authored
      This escapes special characters used in POSIX sed to prevent mismatches.
      e.g. `SYNO_Certficiate=*.example.com` would not match a description of
      "*.example.com" and would look to match any number of double quotes (the
      last character in the sed regex prior to certificate description),
      followed by any single character, followed by "example", followed by any
      character, followed by "com".
      
      After this change, it will properly match `*.example.com` and not
      `""zexamplefcom`.
      
      Additionally we now store the certificate description as base64 encoded
      to prevent issues with single quotes.
      
      Tested on DSM 7.0-41222 (VDSM) and DSM 6.2.4-25556 (DS1515+).
      74a4a788
  20. 19 May, 2021 1 commit
  21. 07 May, 2021 1 commit
  22. 05 May, 2021 1 commit
  23. 02 May, 2021 1 commit
    • Brian Hartvigsen's avatar
      FIX: Synology sets "default" on wrong certificate · 1a4a180e
      Brian Hartvigsen authored
      For some DSM installs, it appears that setting the "default" flag to the
      string "false" actually sets it to true.  This causes Synology to set
      the last updated certificate to be the default certificate.  Using an
      empty string appears to still be accepted as a false-y value for DSMs
      where this isn't happening and corrects the behavior in the cases that
      it was.
      
      Credit to @Run-King for identifying the fix and @buxm for reporting.
      1a4a180e
  24. 30 Mar, 2021 2 commits
  25. 29 Mar, 2021 1 commit
    • Christophe Le Guern's avatar
      Use 'vault kv put' instead of 'vault write' · cc90f834
      Christophe Le Guern authored
      When using vault_cli with a kv2 path, it isn't working. I have the following error:
      ```
      WARNING! The following warnings were returned from Vault:                                                                                                                                                                                     
                                                                                                                                                                                                                                                    
        * Invalid path for a versioned K/V secrets engine. See the API docs for the                                                                                                                                                                 
        appropriate API endpoints to use. If using the Vault CLI, use 'vault kv put'                                                                                                                                                                
        for this operation.                                                                                                                                                                                                                         
      ```
      The new way to write data  is to use `vault kv put`, it is compatible with kv1 and kv2.
      Ref: https://www.vaultproject.io/docs/commands#reading-and-writing-data
      ```
      The original version of K/V used the common read and write operations. A more advanced K/V Version 2 engine was released in Vault 0.10 and introduced the kv get and kv put commands.
      ```
      cc90f834
  26. 26 Mar, 2021 1 commit
  27. 21 Mar, 2021 1 commit
    • Mike Edmunds's avatar
      Fix: Unifi deploy hook support Unifi Cloud Key (#3327) · 06fb3d94
      Mike Edmunds authored
      * fix: unifi deploy hook also update Cloud Key nginx certs
      
      When running on a Unifi Cloud Key device, also deploy to
      /etc/ssl/private/cloudkey.{crt,key} and reload nginx. This
      makes the new cert available for the Cloud Key management
      app running via nginx on port 443 (as well as the port 8443
      Unifi Controller app the deploy hook already supported).
      
      Fixes #3326
      
      * Improve settings documentation comments
      
      * Improve Cloud Key pre-flight error messaging
      
      * Fix typo
      
      * Add support for UnifiOS (Cloud Key Gen2)
      
      Since UnifiOS does not use the Java keystore (like a Unifi
      Controller or Cloud Key Gen1 deploy), this also reworks
      the settings validation and error messaging somewhat.
      
      * PR review fixes
      
      * Detect unsupported Cloud Key java keystore location
      
      * Don't try to restart inactive services
      
      (and remove extra spaces from reload command)
      
      * Clean up error messages and internal variables
      
      * Change to _getdeployconf/_savedeployconf
      
      * Switch from cp to cat to preserve file permissions
      06fb3d94