Unverified Commit b5716ee8 authored by Bjorn Svensson's avatar Bjorn Svensson Committed by GitHub
Browse files

Valgrind returns error exit code when errors found (#1011)

By default Valgrind will return the exit code from the tested process.
Since our test can return 0 (ALL TESTS PASS) even when a leak was
found we need to tell Valgrind to return an error code.
This will fail the CI job when issues are found.
parent 1aed21a8
...@@ -36,7 +36,7 @@ jobs: ...@@ -36,7 +36,7 @@ jobs:
# - name: Run tests under valgrind # - name: Run tests under valgrind
# env: # env:
# SKIPS_AS_FAILS: 1 # SKIPS_AS_FAILS: 1
# TEST_PREFIX: valgrind --track-origins=yes --leak-check=full # TEST_PREFIX: valgrind --error-exitcode=99 --track-origins=yes --leak-check=full
# run: $GITHUB_WORKSPACE/test.sh # run: $GITHUB_WORKSPACE/test.sh
centos7: centos7:
...@@ -75,7 +75,7 @@ jobs: ...@@ -75,7 +75,7 @@ jobs:
env: env:
SKIPS_AS_FAILS: 1 SKIPS_AS_FAILS: 1
TEST_SSL: 1 TEST_SSL: 1
TEST_PREFIX: valgrind --track-origins=yes --leak-check=full TEST_PREFIX: valgrind --error-exitcode=99 --track-origins=yes --leak-check=full
run: $GITHUB_WORKSPACE/test.sh run: $GITHUB_WORKSPACE/test.sh
centos8: centos8:
...@@ -115,7 +115,7 @@ jobs: ...@@ -115,7 +115,7 @@ jobs:
env: env:
SKIPS_AS_FAILS: 1 SKIPS_AS_FAILS: 1
TEST_SSL: 1 TEST_SSL: 1
TEST_PREFIX: valgrind --track-origins=yes --leak-check=full TEST_PREFIX: valgrind --error-exitcode=99 --track-origins=yes --leak-check=full
run: $GITHUB_WORKSPACE/test.sh run: $GITHUB_WORKSPACE/test.sh
macos: macos:
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment