Unverified Commit c7111617 authored by Stan Hu's avatar Stan Hu
Browse files

Improve example for SSL initialization in README.md

The previous example left `ssl_error`
uninitialized. `redisCreateSSLContex` is not guaranteed to set this
when no error occurs.

Use the `REDIS_SSL_CTX_NONE` constant instead of 0 to be precise.
parent 0865c115
...@@ -604,7 +604,7 @@ redisSSLContext *ssl_context; ...@@ -604,7 +604,7 @@ redisSSLContext *ssl_context;
/* An error variable to indicate what went wrong, if the context fails to /* An error variable to indicate what went wrong, if the context fails to
* initialize. * initialize.
*/ */
redisSSLContextError ssl_error; redisSSLContextError ssl_error = REDIS_SSL_CTX_NONE;
/* Initialize global OpenSSL state. /* Initialize global OpenSSL state.
* *
...@@ -622,11 +622,11 @@ ssl_context = redisCreateSSLContext( ...@@ -622,11 +622,11 @@ ssl_context = redisCreateSSLContext(
"redis.mydomain.com", /* Server name to request (SNI), optional */ "redis.mydomain.com", /* Server name to request (SNI), optional */
&ssl_error); &ssl_error);
if(ssl_context == NULL || ssl_error != 0) { if(ssl_context == NULL || ssl_error != REDIS_SSL_CTX_NONE) {
/* Handle error and abort... */ /* Handle error and abort... */
/* e.g. /* e.g.
printf("SSL error: %s\n", printf("SSL error: %s\n",
(ssl_error != 0) ? (ssl_error != REDIS_SSL_CTX_NONE) ?
redisSSLContextGetError(ssl_error) : "Unknown error"); redisSSLContextGetError(ssl_error) : "Unknown error");
// Abort // Abort
*/ */
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment