You need to sign in or sign up before continuing.
Commit e30c96eb authored by NanXiao's avatar NanXiao Committed by Matt Stancliff
Browse files

Add empty pointer check in error cleanup

If realloc fails, the curargv will be NULL.

Closes #253
parent d1e820d8
...@@ -895,12 +895,13 @@ int redisvFormatCommand(char **target, const char *format, va_list ap) { ...@@ -895,12 +895,13 @@ int redisvFormatCommand(char **target, const char *format, va_list ap) {
return totlen; return totlen;
err: err:
while(argc--) if (curargv) {
sdsfree(curargv[argc]); while(argc--)
free(curargv); sdsfree(curargv[argc]);
free(curargv);
}
if (curarg != NULL) sdsfree(curarg);
sdsfree(curarg);
/* No need to check cmd since it is the last statement that can fail, /* No need to check cmd since it is the last statement that can fail,
* but do it anyway to be as defensive as possible. */ * but do it anyway to be as defensive as possible. */
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment