Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
ruanhaishen
hiredis
Commits
f0bdf840
Unverified
Commit
f0bdf840
authored
Nov 14, 2022
by
filipe oliveira
Committed by
GitHub
Nov 14, 2022
Browse files
Add support for nan in RESP3 double (#1133)
parent
991b0b0b
Changes
2
Hide whitespace changes
Inline
Side-by-side
read.c
View file @
f0bdf840
...
@@ -303,11 +303,13 @@ static int processLineItem(redisReader *r) {
...
@@ -303,11 +303,13 @@ static int processLineItem(redisReader *r) {
d
=
INFINITY
;
/* Positive infinite. */
d
=
INFINITY
;
/* Positive infinite. */
}
else
if
(
len
==
4
&&
strcasecmp
(
buf
,
"-inf"
)
==
0
)
{
}
else
if
(
len
==
4
&&
strcasecmp
(
buf
,
"-inf"
)
==
0
)
{
d
=
-
INFINITY
;
/* Negative infinite. */
d
=
-
INFINITY
;
/* Negative infinite. */
}
else
if
(
len
==
3
&&
strcasecmp
(
buf
,
"nan"
)
==
0
)
{
d
=
NAN
;
/* nan. */
}
else
{
}
else
{
d
=
strtod
((
char
*
)
buf
,
&
eptr
);
d
=
strtod
((
char
*
)
buf
,
&
eptr
);
/* RESP3 only allows "inf", "-inf", and finite values, while
/* RESP3 only allows "inf", "-inf", and finite values, while
* strtod() allows other variations on infinity,
NaN,
* strtod() allows other variations on infinity,
* etc. We explicity handle our two allowed infinite cases
* etc. We explicity handle our two allowed infinite cases
and NaN
* above, so strtod() should only result in finite values. */
* above, so strtod() should only result in finite values. */
if
(
buf
[
0
]
==
'\0'
||
eptr
!=
&
buf
[
len
]
||
!
isfinite
(
d
))
{
if
(
buf
[
0
]
==
'\0'
||
eptr
!=
&
buf
[
len
]
||
!
isfinite
(
d
))
{
__redisReaderSetError
(
r
,
REDIS_ERR_PROTOCOL
,
__redisReaderSetError
(
r
,
REDIS_ERR_PROTOCOL
,
...
...
test.c
View file @
f0bdf840
...
@@ -674,12 +674,13 @@ static void test_reply_reader(void) {
...
@@ -674,12 +674,13 @@ static void test_reply_reader(void) {
freeReplyObject
(
reply
);
freeReplyObject
(
reply
);
redisReaderFree
(
reader
);
redisReaderFree
(
reader
);
test
(
"
Set error when
RESP3 double
is
NaN: "
);
test
(
"
Correctly parses
RESP3 double NaN: "
);
reader
=
redisReaderCreate
();
reader
=
redisReaderCreate
();
redisReaderFeed
(
reader
,
",nan
\r\n
"
,
6
);
redisReaderFeed
(
reader
,
",nan
\r\n
"
,
6
);
ret
=
redisReaderGetReply
(
reader
,
&
reply
);
ret
=
redisReaderGetReply
(
reader
,
&
reply
);
test_cond
(
ret
==
REDIS_ERR
&&
test_cond
(
ret
==
REDIS_OK
&&
strcasecmp
(
reader
->
errstr
,
"Bad double value"
)
==
0
);
((
redisReply
*
)
reply
)
->
type
==
REDIS_REPLY_DOUBLE
&&
isnan
(((
redisReply
*
)
reply
)
->
dval
));
freeReplyObject
(
reply
);
freeReplyObject
(
reply
);
redisReaderFree
(
reader
);
redisReaderFree
(
reader
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment