1. 29 Sep, 2016 1 commit
  2. 09 Jul, 2016 1 commit
  3. 07 Jul, 2016 1 commit
  4. 20 Jun, 2016 7 commits
  5. 14 May, 2016 3 commits
  6. 13 May, 2016 1 commit
  7. 12 May, 2016 1 commit
    • not-a-robot's avatar
      Auto merge of #378 - thomaslee:tom_fix_kfreebsd, r=badboy · e93c05a7
      not-a-robot authored
      Fix strerror_r on some esoteric platforms
      
      Defining _XOPEN_SOURCE=1 causes strange behavior on Debian kfreebsd archs -- i.e. the GNU userspace with FreeBSD kernel -- when _GNU_SOURCE is not defined (the default).
      
      Not sure I fully understand the bizarre semantics, but it seems to use the XSI-compliant interface (int strerror_r(int, char*, size_t)) but the GNU implementation (char *strerror_r(int, char*, size_t)) such that strerror_r returns 32-bits of a 64-bit char * on x86_64 kfreebsd. We would expect strerror_r to return zero when using the XSI-compliant strerror_r implementation or a 64-bit char* when using the GNU version. Instead, we get something in between!
      
      Unless I'm missing something, being more explicit about what version of _XOPEN_SOURCE we want seems to be the prudent thing to do here -- and if folks want the GNU implementation of strerror_r for some reason they can always -D_GNU_SOURCE explicitly.
      e93c05a7
  8. 20 Apr, 2016 25 commits