- 08 Apr, 2014 4 commits
-
-
Matt Stancliff authored
Some environments require binding to specific source addresses instead of letting the system determine which IP a connection should originate from. Closes #233
-
Matt Stancliff authored
All the assignments to cb are inside conditionals, so it's vaguely possible it never gets initialized before we try to read from it with (cb.fn == NULL). Condition discovered with scan-build. Closes #229
-
Matt Stancliff authored
redisCheckSocketError should only CheckSocketError and not close any misbehaving sockets. If CheckSocketError discovers a problem, the caller will discover the contest is in ERR and will start destroying the context (which involves finalizing all callbacks (which may still be using fd for something, so we should not close fd until all callbacks have been told we are failing) and eventually close the fd in redisFree() immediately before the context is released).
-
Matt Stancliff authored
With all the async connects and disconnects and error handling going on in hiredis, we need to centralize how we close our fd and set it so it doesn't get re-closed. Prior to this commit, sometimes we'd close(fd), run an async error handler, then call close(fd) again. To stop multiple closes, we now set fd to -1 after we free it, but that requires not passing fd as an independent argument to functions. This commit moves all fd usage to c->fd. Since the context has a fd field and all functions receive the context, it makes more sense to use the fd inside of c instead of passing along fd as an independent argument. Also, by only using c->fd, we can set c->fd after we close it to signify we shouldn't re-close the same fd again. This does change one semi-public interface function redisCheckSocketError() to only take (context) instead of (context, fd). A search on github returned zero occasions of people using redisCheckSocketError() outside of net.{c,h} in hiredis itself. Commit inspired by the bug report at: https://groups.google.com/forum/#!topic/redis-db/mQm46XkIPOY Thanks go out to Thijs for trying high-frequency reconnects on a host that isn't there. Closes #230
-
- 15 Jan, 2014 3 commits
-
-
Pieter Noordhuis authored
Fix a couple of bugs uncovered by the Clang static analyzer
-
Charlie Somerville authored
-
Charlie Somerville authored
-
- 11 Jul, 2013 18 commits
-
-
Pieter Noordhuis authored
-
antirez authored
redisContextConnectTcp() is now able to use IPv6 addresses if there is no IPv4 address found resolving the specified hostname.
-
antirez authored
This makes possible to use the example with IPv6 addresses and/or with a different Redis instance than 127.0.0.1:6379.
-
Noah Williamsson authored
The struct timeval argument in redisConnectWithTimeout(), redisConnectUnixWithTimeout(), redisSetTimeout(), redisContextSetTimeout(), redisContextConnectTcp() and redisContextConnectUnix() is never modified and can therefore be marked as const. Signed-off-by:
Noah Williamsson <noah.williamsson@gmail.com>
-
Pieter Noordhuis authored
-
Pieter Noordhuis authored
constify: constify some variables / functions
-
Wolfgang Richter authored
Closes #121.
-
Pieter Noordhuis authored
-
Pieter Noordhuis authored
-
Rafael Zanella authored
Added a call to redisFree() Closes #148.
-
Aaron Bedra authored
Closes #166.
-
Pieter Noordhuis authored
-
Pieter Noordhuis authored
Closes #172.
-
Pieter Noordhuis authored
-
Pieter Noordhuis authored
Fixes #176.
-
Pieter Noordhuis authored
va_copy must be followed by va_end
-
Pieter Noordhuis authored
-
Pieter Noordhuis authored
-
- 02 Jul, 2013 2 commits
-
-
Erik Dubbelboer authored
-
Richard Fuchs authored
-
- 09 Jun, 2013 1 commit
-
-
Erik Dubbelboer authored
-
- 04 Jun, 2013 1 commit
-
-
Erik Dubbelboer authored
-
- 08 May, 2013 1 commit
-
-
Pieter Noordhuis authored
Fix possible uninitialized value access due to strerror_r error
-
- 07 May, 2013 1 commit
-
-
Eugene Bolotin authored
-
- 01 May, 2013 4 commits
-
-
Pieter Noordhuis authored
See pull request #153.
-
Pieter Noordhuis authored
-
Pieter Noordhuis authored
Also see pull request #161.
-
Pieter Noordhuis authored
-
- 29 Apr, 2013 1 commit
-
-
Allen.Dou authored
Make Connection KeepAlive being optional instead of default.
-
- 19 Apr, 2013 1 commit
-
-
Allen.Dou authored
Keep client alive even though no command was sent to server for a long time.
-
- 10 Apr, 2013 1 commit
-
-
Pieter Noordhuis authored
Set error on invalid timval values for redisConnectWithTimeout (Fixes #154)
-
- 15 Mar, 2013 2 commits
-
-
Aaron Bedra authored
Closes #154 This commit properly sets the error value inside of redisContextWaitReady when an invalid sec or usec value is provided. Tests for each case are provided to demonstrate that the issue is properly fixed and to avoid regression. Signed-off-by:
Aaron Bedra <aaron@aaronbedra.com>
-
Pieter Noordhuis authored
-