1. 19 Sep, 2014 1 commit
  2. 18 Sep, 2014 1 commit
  3. 29 May, 2014 3 commits
  4. 10 Apr, 2014 4 commits
  5. 09 Apr, 2014 10 commits
  6. 08 Apr, 2014 4 commits
    • Matt Stancliff's avatar
      Add ability to bind source address on connect · 37d25a39
      Matt Stancliff authored
      Some environments require binding to specific source addresses instead
      of letting the system determine which IP a connection should originate
      from.
      
      Closes #233
      37d25a39
    • Matt Stancliff's avatar
      Fix potential undefined struct read · 61eeedbe
      Matt Stancliff authored
      All the assignments to cb are inside conditionals, so it's
      vaguely possible it never gets initialized before we try
      to read from it with (cb.fn == NULL).
      
      Condition discovered with scan-build.
      
      Closes #229
      61eeedbe
    • Matt Stancliff's avatar
      Stop redisCheckSocketError from more than checking · e35266e6
      Matt Stancliff authored
      redisCheckSocketError should only CheckSocketError and not
      close any misbehaving sockets.  If CheckSocketError discovers
      a problem, the caller will discover the contest is in ERR
      and will start destroying the context (which involves
      finalizing all callbacks (which may still be using
      fd for something, so we should not close fd until all
      callbacks have been told we are failing) and eventually
      close the fd in redisFree() immediately before the
      context is released).
      e35266e6
    • Matt Stancliff's avatar
      Remove possiblity of multiple close on same fd · 7f0c7a29
      Matt Stancliff authored
      With all the async connects and disconnects and error handling
      going on in hiredis, we need to centralize how we close our fd
      and set it so it doesn't get re-closed.  Prior to this commit,
      sometimes we'd close(fd), run an async error handler, then
      call close(fd) again.
      
      To stop multiple closes, we now set fd to -1 after we free it,
      but that requires not passing fd as an independent argument to
      functions.
      
      This commit moves all fd usage to c->fd.  Since the context
      has a fd field and all functions receive the context, it makes
      more sense to use the fd inside of c instead of passing along fd
      as an independent argument.
      
      Also, by only using c->fd, we can set c->fd after we close it to
      signify we shouldn't re-close the same fd again.
      
      This does change one semi-public interface function redisCheckSocketError()
      to only take (context) instead of (context, fd).  A search on github
      returned zero occasions of people using redisCheckSocketError()
      outside of net.{c,h} in hiredis itself.
      
      Commit inspired by the bug report at:
      https://groups.google.com/forum/#!topic/redis-db/mQm46XkIPOY
      
      Thanks go out to Thijs for trying high-frequency reconnects on
      a host that isn't there.
      
      Closes #230
      7f0c7a29
  7. 15 Jan, 2014 3 commits
  8. 11 Jul, 2013 14 commits