- 05 Jan, 2015 14 commits
-
-
Matt Stancliff authored
External callers may not know about sdsfree, so let's give them an easy way to know how to free their sds result.
-
Mareq authored
[Cleaned up: - name of function: freeRedis... -> redisFree... - return value of function (free doesn't return anything) - parameter type for function. - we don't need to free a char**, the char** is just for returning from the assignment functoin.] Closes #250
-
Chris Lamb authored
Signed-off-by:
Chris Lamb <chris@chris-lamb.co.uk> [Instead of checking for "not solaris" we feature detect for availability of what we want, then remove the system that advertises compatability but doesn't actually provide it (given our assumptions about what we're guarding).] Closes #254
-
Matt Stancliff authored
redisAsyncInitialize() can return NULL, but then we pass the return value from redisAsyncInitialize() into something dereferencing the return value, which can cause crashies.
-
mike authored
[This introduces some new API functions.] * Adds new flag to the connection context indicating SO_REUSEADDR should be set. * Adds max number of retries constant for when connect() hits EADDRNOTAVAIL. * Adds new function, redisAsyncConnectBindWithReuse(), letting clients enable this functionality. [Removed trailing whitespace in new header lines.] Closes #264
-
jinguoli authored
[It doesn't _actually_ matter, but technically the order argument is: (number of items, size of items)] Closes #279
-
torque authored
This: - Removes misplaced libuv function prototype - Includes stdlib for free() Closes #251
-
michael-grunder authored
OK, perhaps the second time is a charm. I forgot that I had hiredis forked from a long time ago, so the initial pull request was hosed. :) * Pulled in sdscatfmt() from Redis, and modified it to accept a size_t (%T) style format specifier. * Pulled in sdsll2str() and sdsull2str() from Redis (needed by sdscatfmt). * Added a new method, redisFormatSdsCommandArgv() which takes and sds* as the target, rather than char* (and uses sdscatfmt instead of sprintf for the construction). I get roughly the following improvement: Old: 1.044806 New: 0.481620 The benchmark code itself can be found here: https://gist.github.com/michael-grunder/c92ef31bb632b3d0ad81 Closes #260
-
Hang Su authored
'const' where we can. Closes #268
-
Chris Williams authored
Closes #267
-
Gary Grossman authored
"sdscatpritf" -> "sdscatprintf" Example used sdsempty("text") but should say sdsnew("text") Closes #282
-
Mohnish Thallavajhula authored
Closes #285
-
Jan-Erik Rediger authored
If the string is already in the dict, we need to free this. Original fix by @tt33415366. Fixes #256 Closes #286
-
Ryan Jacobs authored
Closes #293
-
- 19 Sep, 2014 1 commit
-
-
Salvatore Sanfilippo authored
Fix getaddrinfo() memory leak
-
- 18 Sep, 2014 1 commit
-
-
Matt Stancliff authored
See antirez/redis#2012 for the leak causing unbounded memory growth.
-
- 29 May, 2014 3 commits
-
-
Pieter Noordhuis authored
Less surprising behaviour in redisFree() and freeReplyObject()
-
Daniel Melani authored
Test that redisFree() and freeReplyObject() do not crash when NULL is passed in.
-
Daniel Melani authored
Make redisFree() and freeReplyObject() less surprising by behaving just like free(). That is, don't crash when passing in NULL.
-
- 10 Apr, 2014 4 commits
-
-
Pieter Noordhuis authored
Closes #219.
-
Pieter Noordhuis authored
-
Pieter Noordhuis authored
-
Pieter Noordhuis authored
Next version of hiredis
-
- 09 Apr, 2014 10 commits
-
-
Matt Stancliff authored
Solaris doesn't define the TCP options we try to set. Let's ignore those under Solaris. Closes #207
-
Eddy Jansson authored
The existing way is not compatible with a lot of shells, including most bash installations, because the echos that generates the configuration sent to redis-server doesn't expand the escapes. Adding '-e' to the echo works under bash, but breaks on the Travis CI server. This is my attempt to find an alternative that works everywhere. [committer note: it doesn't work under Solaris make, but the Makefile was already broken under Solaris make. Solaris users must use gmake.] Closes #224 and Closes #221
-
antirez authored
This is a backport of https://github.com/antirez/redis/commit/d01aad329c259a7276c448cee6696b04dfa6f8c1
-
antirez authored
SDS is now broken out of Redis into its own project, so include the latest version from the SDS repo. This is a backport of the Redis commit doing the same to the bundled hiredis: https://github.com/antirez/redis/commit/320fa02b9b48ee1c63d88db6344fc0d328e24853
-
Patrick TJ McPhee authored
This is backported from https://github.com/antirez/redis/commit/289942b6259670fe3dcfaffdd0135c27f14c61c0
-
Charlie Somerville authored
Closes #206
-
Axel Etcheverry authored
Closes #202
-
John Graham authored
Closes #189
-
ripcurld00d authored
Closes #186
-
Eddy Jansson authored
These allows for easier integration of hiredis with external code that wants to manage its fds, say for instance in a pool. Closes #223
-
- 08 Apr, 2014 4 commits
-
-
Matt Stancliff authored
Some environments require binding to specific source addresses instead of letting the system determine which IP a connection should originate from. Closes #233
-
Matt Stancliff authored
All the assignments to cb are inside conditionals, so it's vaguely possible it never gets initialized before we try to read from it with (cb.fn == NULL). Condition discovered with scan-build. Closes #229
-
Matt Stancliff authored
redisCheckSocketError should only CheckSocketError and not close any misbehaving sockets. If CheckSocketError discovers a problem, the caller will discover the contest is in ERR and will start destroying the context (which involves finalizing all callbacks (which may still be using fd for something, so we should not close fd until all callbacks have been told we are failing) and eventually close the fd in redisFree() immediately before the context is released).
-
Matt Stancliff authored
With all the async connects and disconnects and error handling going on in hiredis, we need to centralize how we close our fd and set it so it doesn't get re-closed. Prior to this commit, sometimes we'd close(fd), run an async error handler, then call close(fd) again. To stop multiple closes, we now set fd to -1 after we free it, but that requires not passing fd as an independent argument to functions. This commit moves all fd usage to c->fd. Since the context has a fd field and all functions receive the context, it makes more sense to use the fd inside of c instead of passing along fd as an independent argument. Also, by only using c->fd, we can set c->fd after we close it to signify we shouldn't re-close the same fd again. This does change one semi-public interface function redisCheckSocketError() to only take (context) instead of (context, fd). A search on github returned zero occasions of people using redisCheckSocketError() outside of net.{c,h} in hiredis itself. Commit inspired by the bug report at: https://groups.google.com/forum/#!topic/redis-db/mQm46XkIPOY Thanks go out to Thijs for trying high-frequency reconnects on a host that isn't there. Closes #230
-
- 15 Jan, 2014 3 commits
-
-
Pieter Noordhuis authored
Fix a couple of bugs uncovered by the Clang static analyzer
-
Charlie Somerville authored
-
Charlie Somerville authored
-