1. 26 Jun, 2022 10 commits
  2. 04 May, 2022 1 commit
  3. 24 Apr, 2022 1 commit
    • Orgad Shaneh's avatar
      Fix warnings on Win64 · eedb37a6
      Orgad Shaneh authored
      read.c:399:27: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
        399 |                     obj = (void*)(long)cur->type;
            |                           ^
      eedb37a6
  4. 23 Apr, 2022 4 commits
  5. 22 Apr, 2022 2 commits
  6. 05 Apr, 2022 2 commits
  7. 03 Feb, 2022 1 commit
    • Björn Svensson's avatar
      Handle any pipelined unsubscribe in async · 7123b87f
      Björn Svensson authored
      Redis responds to an unsubscribe with one or many replies, depending
      on the current subscribe state. When channels/patterns names are
      provided in a command each given name will trigger a reply even if
      duplicated or not subscribed to.
      To know when we can return from the subscribed state we need to do
      bookkeeping on pending additional unsubscribe replies, and make sure
      we receive them all before switching state.
      7123b87f
  8. 02 Feb, 2022 2 commits
  9. 01 Feb, 2022 4 commits
  10. 28 Jan, 2022 1 commit
    • Bjorn Svensson's avatar
      Avoid incorrect call to the previous reply's callback (#1040) · be41ed60
      Bjorn Svensson authored
      * No reuse of the previous reply callback
      
      When multiple replies are parsed from a socket in one read
      a previously found callback might get reused when the current
      reply has no known callback.
      
      This can be triggered by the added testcase which unsubscribe to
      subscribed (A,B) and a non-subscribed channel (X).
      Without this correction a callback for wrong channel is called.
      -  In 'unsubscribe B X A', B's callback is called when handling X.
      -  Now this is not done, i.e. there is no callback called for X.
      
      * Re-push monitor callback for each reply
      
      MONITORING used the same callback for all replies while parsing
      multiple responses. This handling was changed to avoid calling
      the wrong callback in some scenarios.
      Now also change monitorings repush to work with this change.
      
      Includes an added async monitoring testcase.
      be41ed60
  11. 24 Jan, 2022 1 commit
  12. 18 Jan, 2022 2 commits
  13. 11 Jan, 2022 1 commit
    • Bjorn Svensson's avatar
      Correction for command timeout during pubsub (#1038) · ff860e55
      Bjorn Svensson authored
      * Add test of command timeout during pubsub
      
      A timeout of a non-subscribe command will be ignored during pubsub.
      It will be handled as an idle timeout and a response is awaited for.
      
      * Correction for command timeout during pubsub
      
      Disconnect when a sent non-subscribe command triggers a timeout.
      ff860e55
  14. 09 Jan, 2022 1 commit
    • Fabrice Fontaine's avatar
      CMakeLists.txt: allow building without a C++ compiler (#872) · 24d53449
      Fabrice Fontaine authored
      Define hiredis as a C project (and use a single PROJECT statement) to
      avoid the following build failure if a C++ compiler is not found:
      
      CMake Error at CMakeLists.txt:3 (PROJECT):
        The CMAKE_CXX_COMPILER:
      
          /srv/storage/autobuild/run/instance-1/output-1/host/bin/arm-linux-g++
      
        is not a full path to an existing compiler tool.
      
        Tell CMake where to find the compiler by setting either the environment
        variable "CXX" or the CMake cache entry CMAKE_CXX_COMPILER to the full path
        to the compiler, or to the compiler name if it is in the PATH.
      
      The only cpp source file is examples/example-qt.cpp which is never
      compiled with cmake buildsystem. This file is compiled only with the
      Makefile buildsystem so perhaps it should be removed. If it is added to
      the cmake buildsystem, a call to enable_language(CXX) will have to be
      added.
      
      Fixes:
       - http://autobuild.buildroot.org/results/830ec3398cd29b9fc5cde06a225ef531d7a9d850
      
      Signed-off-by: default avatarFabrice Fontaine <fontaine.fabrice@gmail.com>
      24d53449
  15. 05 Jan, 2022 1 commit
  16. 24 Dec, 2021 1 commit
  17. 23 Dec, 2021 1 commit
    • zhenwei pi's avatar
      Makefile: move SSL options into a block and refine rules · f74b0818
      zhenwei pi authored
      
      
      Move SSL options into two blocks to make it easy to read:
        1, first part: SSL variables part
        1, second part: SSL building rules part
      and change global rules to make it easy to maintain. For the further
      step, it gets extensible to add another type.
      
      New version of the library building rule:
      	static: $(STLIBNAME) $(SSL_STLIB)
      	dynamic: $(DYLIBNAME) $(SSL_DYLIB)
      
      Compare with the orignal version:
      	dynamic: $(DYLIBNAME)
      	static: $(STLIBNAME)
      	ifeq ($(USE_SSL),1)
      	dynamic: $(SSL_DYLIBNAME)
      	static: $(SSL_STLIBNAME)
      	endif
      
      If we want to add a new type(Ex, RDMA), for the new version, we can
      do like this:
      	########### RDMA variables start ###############
      	.....
      	########### RDMA variables end   ###############
      
      	static: $(STLIBNAME) $(SSL_STLIB) $(RDMA_STLIB)
      	dynamic: $(DYLIBNAME) $(SSL_DYLIB) $(RDMA_DYLIB)
      
      	########### RDMA building rules start ###############
      	.....
      	########### RDMA building rules end   ###############
      Signed-off-by: default avatarzhenwei pi <pizhenwei@bytedance.com>
      f74b0818
  18. 22 Dec, 2021 3 commits
    • Eric Deng's avatar
      Update CMakeLists.txt for more portability (#1005) · f347743b
      Eric Deng authored
      add alias hiredis::hiredis and hiredis::hiredis_static so when this project is FetchContent, it behave the same as find_package-ed.
      e.g.
      ```
      find_package(hiredis 1.0.2 QUIET)
      if (NOT hiredis_FOUND)
          FetchContent_Declare(
                  hiredis
                  GIT_REPOSITORY https://github.com/redis/hiredis.git
                  GIT_TAG v1.0.2
          )
          FetchContent_MakeAvailable(hiredis)
      endif ()
      # later
      target_link_libraries(target **hiredis::hiredis**) #can always use hiredis::hiredis to ref to this project. no matter find_package or FetchContent
      ```
      this is actually sort of best practice when making a CMake lib.
      f347743b
    • sundb's avatar
      f2be7480
    • Bjorn Svensson's avatar
      Handle array response in parallell with pubsub using RESP3 (#1014) · 58aacdac
      Bjorn Svensson authored
      RESP3 allows sending commands in parallell with pubsub handling
      and these commands might get responded with a REDIS_REPLY_ARRAY.
      This conflicts with the pubsub response handling for RESP2 and
      results in a faulty state when using RESP3.
      
      Add functionality to keep track of PUSH/RESP3 support on the connection
      and only expect the message type REDIS_REPLY_PUSH as subscribe messages
      when once seen.
      58aacdac
  19. 16 Dec, 2021 1 commit
    • Bjorn Svensson's avatar
      Support PING while subscribing (RESP2) (#1027) · d3384260
      Bjorn Svensson authored
      * Handle PING during pubsub in RESP2
      
      * Rename invalid callback list
      
      Some commands are valid to send during a subscribe in RESP2, and
      most in RESP3. Renaming the callback list from `invalid` to `replies`
      to detail this fact.
      
      * Fix review comment
      d3384260