- 03 Apr, 2020 1 commit
-
-
Michael Grunder authored
Unit tests in Windows and a Windows timeout fix This commit gets our unit tests compiling and running on Windows as well as removes a duplicated `timeval` -> `DWORD` conversion logic in sockcompat.c There are minor differences in behavior between Linux and Windows to note: 1. In Windows, opening a non-existent hangs forever in WSAPoll whereas it correctly returns with a "Connection refused" error on Linux. For that reason, I simply skip this test in Windows. It may be related to this known issue: https://daniel.haxx.se/blog/2012/10/10/wsapoll-is-broken/ 2. Timeouts are handled slightly differently in Windows and Linux. In Linux, we intentionally set REDIS_ERR_IO for connection timeouts whereas in Windows we set REDIS_ERR_TIMEOUT. It may be prudent to fix this discrepancy although there are almost certainly users relying on the current behavior.
-
- 12 Dec, 2019 1 commit
-
-
michael-grunder authored
We currently perform a NULL check in redisGetReply and don't push the reply back to the caller, but we don't free any reply meaning that this will leak memory: redisGetReply(context, NULL); This change simply frees the reply if we were passed NULL. Addresses #740
-
- 25 Sep, 2019 1 commit
-
-
michael-grunder authored
redisFormatSdsCommandArgv takes an sds* and calls sdsempty() for us. Addresses #714
-
- 16 Sep, 2019 1 commit
-
-
Yossi Gottlieb authored
This repeats all existing tests in SSL mode, but does not yet provide SSL-specific tests.
-
- 14 May, 2019 1 commit
-
-
Eivind Uggedal authored
This makes the tests pass on musl[1] based distros like Alpine Linux. [1]: https://www.musl-libc.org/
-
- 31 Mar, 2019 1 commit
-
-
michael-grunder authored
As it turns out 'idontexist.com' actually does exist.
-
- 26 Nov, 2018 1 commit
-
-
David Carlier authored
-
- 26 Sep, 2018 1 commit
-
-
Mark Nunberg authored
Some ISPs like to inject their own "Suggestions" page whenever you hit NXDOMAIN. This confuses Redis as well as addrinfo (black-holing the route).
-
- 21 May, 2018 1 commit
-
-
Justin Brewer authored
This makes createArray consistent with createString, which also takes size_t. Bounds-check and unit tests are updated to allow up to min(SIZE_MAX,LLONG_MAX). Changelog is updated to mention this API break. Signed-off-by:
Justin Brewer <jzb0012@auburn.edu>
-
- 20 May, 2018 3 commits
-
-
michael-grunder authored
-
michael-grunder authored
-
Justin Brewer authored
processMultiBulkItem truncates the value read from readLongLong, resulting in a corrupted state when the next item is read. createArray takes an int, so bound to INT_MAX. Inspection showed that processBulkItem had the same truncation issue. createString takes size_t, so bound to SIZE_MAX. This only has an effect on 32-bit platforms. A strict lower bound is also added, since negative lengths other than -1 are invalid according to RESP. Signed-off-by:
Justin Brewer <jzb0012@auburn.edu>
-
- 19 May, 2018 1 commit
-
-
Justin Brewer authored
Badly formatted or out-of-range integers are now protocol errors. Signed-off-by:
Justin Brewer <jzb0012@auburn.edu>
-
- 14 May, 2016 1 commit
-
-
Jan-Erik Rediger authored
-
- 20 Apr, 2016 1 commit
-
-
owent authored
- fix macro problem in mingw-gcc - fix typedef in cygwin
-
- 17 Apr, 2016 1 commit
-
-
Jerry Jacobs authored
-
- 18 Nov, 2015 1 commit
-
-
Tom Lee authored
It's possible for the call to connect() to succeed on the very first try, in which case the logic for checking for invalid timeout fields is never executed. When this happens, the tests fail because they expect a REDIS_ERR_IO but no such failure has occurred. Tests aside, this is a potential source of irritating and hard-to-find intermittent bugs. This patch forces the validation to occur early so that we get predictable behavior whenever an invalid timeout is specified.
-
- 16 Sep, 2015 1 commit
-
-
olgeni authored
-
- 16 Apr, 2015 2 commits
-
-
Jan-Erik Rediger authored
Originally implemented by @abedra as part of #306. In case a write or read times out, we force an error state, because we can't guarantuee that the next read will get the right data. Instead we need to reconnect to have a clean-state connection, which is now easily possible with this method.
-
Jan-Erik Rediger authored
-
- 18 Feb, 2015 1 commit
-
-
Matt Stancliff authored
Closes #309 (such as when -DNDEBUG disables all assert() macros) Inspired by keith-bennett-gbg, but re-rewritten to be more concise.
-
- 22 Jan, 2015 1 commit
-
-
Matt Stancliff authored
-
- 08 Jan, 2015 2 commits
-
-
Matt Stancliff authored
Suggested at https://github.com/redis/hiredis/issues/294#issuecomment-69153074 This change also makes the test stop hanging for 10 to 30 seconds waiting for the resolver to timeout. Now the resolver immediately sees the hostname is bad and returns error without waiting for timeout.
-
Matt Stancliff authored
Fixes #294
-
- 29 May, 2014 1 commit
-
-
Daniel Melani authored
Test that redisFree() and freeReplyObject() do not crash when NULL is passed in.
-
- 09 Apr, 2014 3 commits
-
-
Axel Etcheverry authored
Closes #202
-
ripcurld00d authored
Closes #186
-
Eddy Jansson authored
These allows for easier integration of hiredis with external code that wants to manage its fds, say for instance in a pool. Closes #223
-
- 11 Jul, 2013 2 commits
-
-
Wolfgang Richter authored
Closes #121.
-
Pieter Noordhuis authored
-
- 01 May, 2013 1 commit
-
-
Pieter Noordhuis authored
-
- 15 Mar, 2013 1 commit
-
-
Aaron Bedra authored
Closes #154 This commit properly sets the error value inside of redisContextWaitReady when an invalid sec or usec value is provided. Tests for each case are provided to demonstrate that the issue is properly fixed and to avoid regression. Signed-off-by:
Aaron Bedra <aaron@aaronbedra.com>
-
- 23 Feb, 2013 1 commit
-
-
Thordur Bjornsson authored
Add strings to allow OpenBSD/OSX to pass.
-
- 22 Jan, 2013 1 commit
-
-
Henri Doreau authored
Updated documentation and examples accordingly.
-
- 28 Aug, 2012 1 commit
-
-
Pieter Noordhuis authored
-
- 20 Dec, 2011 1 commit
-
-
Chip Salzenberg authored
-
- 02 Dec, 2011 1 commit
-
-
mrb authored
-
- 10 Jul, 2011 2 commits
-
-
Pieter Noordhuis authored
-
Pieter Noordhuis authored
-
- 09 Jul, 2011 1 commit
-
-
Pieter Noordhuis authored
There is no way we can guess the width of the argument when we cannot infer its type from the format specifier.
-