- 11 Jul, 2021 1 commit
-
-
Meir Shpilraien (Spielrein) authored
When set hiredis will not automatically free replies in an async context, and the replies must be freed instead by the user. Co-authored-by:
Michael Grunder <michael.grunder@gmail.com>
-
- 02 Apr, 2021 2 commits
-
-
michael-grunder authored
Since redisGetReplyFromReader is exposed in a header file, we probably shouldn't modify how it behaves in any way. For this reason, handle the changed logic in an internal static helper method.
-
michael-grunder authored
RESP3 invalidation messages always seemed to be sent before the response to a given command, but it appears this is not always the case: In Redis 6.2.0RC1 Redis sends the invalidation after the HSET in the following sequence: ``` hget hash field $5 value hset hash field value :0 >2 $10 invalidate *1 $4 hash ``` To account for this possibility just wrap redisGetReplyFromReader in a loop as it is called twice in redisGetReply.
-
- 26 Feb, 2021 4 commits
-
-
Alex Smith authored
-
Alex Smith authored
Per RESP3, push messages are able to contain exactly what array messages can contain (that is, any other type).
-
Alex Smith authored
-
Alex Smith authored
-
- 18 Oct, 2020 1 commit
-
-
michael-grunder authored
When CLIENT TRACKING is enabled, Redis will send an invalidation message with a NIL payload to all tracking clients after a FLUSHDB is executed. We didn't account for REDIS_REPLY_PUSH being a valid parent object to a NIL payload, and were failing an assertion. Additionally this commit adds a regression test for the logic.
-
- 12 Oct, 2020 1 commit
-
-
Guy Korland authored
-
- 29 Jul, 2020 1 commit
-
-
Michael Grunder authored
We need to allow our users to use redisContext->privdata as context for any RESP3 PUSH messages, which means we can't use it for managing SSL connections. Bulletpoints: * Create a secondary redisContext member for internal use only called privctx and rename the redisContextFuncs->free_privdata accordingly. * Adds a `free_privdata` function pointer so the user can tie allocated memory to the lifetime of a redisContext (like they can already do with redisAsyncContext) * Enables SSL tests in .travis.yml
-
- 26 Jul, 2020 1 commit
-
-
valentinogeron authored
Add an additional timeout so the user has a convenient way of controlling distinct connect and command timeouts
-
- 20 Jul, 2020 1 commit
-
-
Michael Grunder authored
Proper support for RESP3 PUSH messages. By default, PUSH messages are now intercepted and the reply memory freed. This means existing code should work unchanged when connecting to Redis >= 6.0.0 even if `CLIENT TRACKING` were then enabled. Additionally, we define two callbacks users can configure if they wish to handle these messages in a custom way: void redisPushFn(void *privdata, void *reply); void redisAsyncPushFn(redisAsyncContext *ac, void *reply); See #825
-
- 19 Jun, 2020 1 commit
-
-
valentinogeron authored
When connecting with a timeout, we shouldn't also call `redisSetTimeout` which will implement a timeout for commands. See related issue #722
-
- 07 Jun, 2020 1 commit
-
-
Michael Grunder authored
Fix overflow bug in `sdsrange`
-
- 22 May, 2020 1 commit
-
-
Michael Grunder authored
* Adds an indirection to every allocation/deallocation to allow users to plug in ones of their choosing (use custom functions, jemalloc, etc). * Gracefully handle OOM everywhere in hiredis. This should make it possible for users of the library to have more flexibility in how they handle such situations. * Changes `redisReaderTask->elements` from an `int` to a `long long` to prevent a possible overflow when transferring the task elements into a `redisReply`. * Adds a configurable `max elements` member to `redisReader` that defaults to 2^32 - 1. This can be set to "unlimited" by setting the value to zero.
-
- 21 May, 2020 1 commit
-
-
Michael Grunder authored
Fixes #815
-
- 19 May, 2020 1 commit
-
-
Michael Grunder authored
Pull RESP3 verbatim string handling from Redis Fixes #802
-
- 12 Dec, 2019 1 commit
-
-
michael-grunder authored
We currently perform a NULL check in redisGetReply and don't push the reply back to the caller, but we don't free any reply meaning that this will leak memory: redisGetReply(context, NULL); This change simply frees the reply if we were passed NULL. Addresses #740
-
- 16 Sep, 2019 1 commit
-
-
Yossi Gottlieb authored
We should not attempt to keep the context and re-establish the TLS connection for several reasons: 1. Maintain symmetry between redisConnect() and redisReconnect(), so in both cases an extra step is required to initiate SSL. 2. The caller may also wish to reconfigure the SSL session and needs a chance to do that. 3. It is not a practical thing to do on an async non-blocking connection context.
-
- 29 Aug, 2019 1 commit
-
-
Yossi Gottlieb authored
-
- 04 Aug, 2019 1 commit
-
-
Yossi Gottlieb authored
This corresponds to commits d5c54f0b..bea09a7f in the redis repository.
-
- 10 Apr, 2019 1 commit
-
-
Mark Nunberg authored
-
- 01 Apr, 2019 3 commits
-
-
m authored
With this change, Hiredis builds with MinGW and runs on Windows.
-
m authored
The redisFD type should be equal to the system native socket file desciptor type (for POSIX, this is a plain int). We also introduce the REDIS_INVALID_FD value, which maps to -1 on POSIX systems.
-
m authored
This makes hiredis.c free from system calls related to socket I/O. This is also makes the treatment of raw socket connections more similar to the SSL backend.
-
- 21 Feb, 2019 1 commit
-
-
Mark Nunberg authored
-
- 20 Feb, 2019 7 commits
-
-
Mark Nunberg authored
-
Mark Nunberg authored
This helps us detect use-after-free
-
valentino authored
-
valentino authored
-
Mark Nunberg authored
also, clean up redisContextInit -- we're just zeoring the struct
-
Mark Nunberg authored
This reduces the boilerplate of all the redisConnectXXX functions, and allows us to provide more connection options in the future.
-
Mark Nunberg authored
-
- 24 Oct, 2018 1 commit
-
-
Stefan Hacker authored
Referred to redisContextReadReply which I cannot find in this codebase nor the old redis-tools one. Presumably this meant to say redisGetReplyFromReader which is how redisBufferRead is used in this file. Could've also meant the interface function redisReaderGetReply.
-
- 26 Sep, 2018 1 commit
-
-
Mark Nunberg authored
This retrieves the actual error which occurred, as getsockopt is not always reliable in this regard.
-
- 21 May, 2018 1 commit
-
-
Justin Brewer authored
This makes createArray consistent with createString, which also takes size_t. Bounds-check and unit tests are updated to allow up to min(SIZE_MAX,LLONG_MAX). Changelog is updated to mention this API break. Signed-off-by:
Justin Brewer <jzb0012@auburn.edu>
-
- 01 May, 2018 3 commits
-
-
Justin Brewer authored
free(NULL) is a valid NOP. Most of the hiredis free functions behave the same way. redisReaderFree is updated to also be NULL-safe. There is one redundant NULL check at sds.c:1036, but it's left as is since sds is imported from upstream. Signed-off-by:
Justin Brewer <jzb0012@auburn.edu>
-
Justin Brewer authored
calloc is guaranteed to provide a zero-initialized buffer. There is no need to set fields to zero explicitly. Signed-off-by:
Justin Brewer <jzb0012@auburn.edu>
-
Justin Brewer authored
Since _GNU_SOURCE is now guaranteed to be unset, it is no longer necessary to support the GNU-specific version of strerror_r. Drop __redis_strerror_r from the header, and call strerror_r directly. This breaks any external users of this macro, but they shouldn't have been using it in the first place. Signed-off-by:
Justin Brewer <jzb0012@auburn.edu>
-
- 05 Jan, 2018 1 commit
-
-
cdliuqiang@gmail.com authored
-