1. 03 Jul, 2019 1 commit
  2. 01 Apr, 2019 4 commits
    • m's avatar
      Port network layer to Winsock · dc6d19b9
      m authored
      With this change, Hiredis builds with MinGW and runs on Windows.
      dc6d19b9
    • m's avatar
      Use recv/send instead of read/write · 1d092a23
      m authored
      The recv/send calls are more portable than read/write, since unlike the
      latter, the former work with Windows sockets.
      
      We also check for EWOULDBLOCK instead of EAGAIN. On most Unices, EAGAIN
      and EWOULDBLBOCK are the same thing. However, on Windows they are
      different, and send/recv are expected to give EWOULDBLOCK for
      non-blocking sockets.
      1d092a23
    • m's avatar
      Introduce a redisFD type · e84086cb
      m authored
      The redisFD type should be equal to the system native socket file
      desciptor type (for POSIX, this is a plain int).
      
      We also introduce the REDIS_INVALID_FD value, which maps to -1 on POSIX
      systems.
      e84086cb
    • m's avatar
      Move network I/O calls to net.c · 1788f41f
      m authored
      This makes hiredis.c free from system calls related to socket I/O. This
      is also makes the treatment of raw socket connections more similar to
      the SSL backend.
      1788f41f
  3. 20 Feb, 2019 2 commits
  4. 28 Jan, 2019 1 commit
  5. 05 Dec, 2018 1 commit
  6. 26 Sep, 2018 3 commits
  7. 01 May, 2018 3 commits
  8. 28 Apr, 2018 2 commits
    • Justin Brewer's avatar
      Strip down fmacros.h · 49bbaacc
      Justin Brewer authored
      
      
      strerror_r and addrinfo require _POSIX_C_SOURCE >= 200112L,  which is
      implied by _XOPEN_SOURCE >= 600. With the removal of AF_LOCAL usage,
      the only non-standard features being used are the TCP_KEEP* socket
      flags. _DARWIN_C_SOURCE is required to expose TCP_KEEPALIVE.
      
      Fall back to using _XOPEN_SOURCE 600 for all platforms, and
      additionally define _DARWIN_C_SOURCE for Darwin.
      Signed-off-by: default avatarJustin Brewer <jzb0012@auburn.edu>
      49bbaacc
    • Justin Brewer's avatar
      Use AF_UNIX · bbeab800
      Justin Brewer authored
      
      
      AF_LOCAL is the old, non-standardized name for AF_UNIX. Just use
      AF_UNIX, rather than wrestling with platform specifics of AF_LOCAL
      definitions.
      Signed-off-by: default avatarJustin Brewer <jzb0012@auburn.edu>
      bbeab800
  9. 15 Jun, 2017 1 commit
  10. 15 May, 2017 1 commit
  11. 30 Dec, 2016 1 commit
  12. 07 Jul, 2016 1 commit
  13. 18 Nov, 2015 1 commit
    • Tom Lee's avatar
      Fix potential race in 'invalid timeout' tests · d4b715f0
      Tom Lee authored
      It's possible for the call to connect() to succeed on the very first
      try, in which case the logic for checking for invalid timeout fields is
      never executed. When this happens, the tests fail because they expect a
      REDIS_ERR_IO but no such failure has occurred.
      
      Tests aside, this is a potential source of irritating and hard-to-find
      intermittent bugs.
      
      This patch forces the validation to occur early so that we get
      predictable behavior whenever an invalid timeout is specified.
      d4b715f0
  14. 30 Apr, 2015 1 commit
    • Alex Balashov's avatar
      Renamed redisContext struct member 'unix' to 'unix_sock' to avoid encountering... · d132d676
      Alex Balashov authored
      Renamed redisContext struct member 'unix' to 'unix_sock' to avoid encountering defined constant 'unix' in GNU C environment (see commit d8145d79).
      
      Not all code using hiredis can compile using '-std=c99', and/or not all users are able to easily make that change to the build process of various open-source projects, so it is more pragmatic to choose a different identifier that does not impose this requirement.
      d132d676
  15. 16 Apr, 2015 2 commits
  16. 05 Jan, 2015 3 commits
    • Matt Stancliff's avatar
      Fix errno error buffers to not clobber errors · cc202324
      Matt Stancliff authored
      The strerror_r API has two flavors depending on system options.
      
      The bad flavor uses a static buffer for returning results, so if
      you save the pointer from strerror_r, the string you're referencing
      becomes useless if anybody else calls strerror_r again
      
      The good flavor does what you expect: it writes the error to your buffer.
      
      This commit uses strerror_r directly if it's a good version or copies
      the static buffer into our private buffer if it's a bad version.
      
      Thanks to gemorin for explaining the problem and drafting a fix.
      
      Fixes #239
      cc202324
    • Chris Lamb's avatar
      Fix build under kfreebsd · 85c6bfb0
      Chris Lamb authored
      
      Signed-off-by: default avatarChris Lamb <chris@chris-lamb.co.uk>
      
      [Instead of checking for "not solaris" we feature detect
      for availability of what we want, then remove the system
      that advertises compatability but doesn't actually provide it
      (given our assumptions about what we're guarding).]
      
      Closes #254
      85c6bfb0
    • mike's avatar
      Add support for SO_REUSEADDR · 7c4d2557
      mike authored
      [This introduces some new API functions.]
      
      * Adds new flag to the connection context indicating SO_REUSEADDR
        should be set.
      * Adds max number of retries constant for when connect() hits
        EADDRNOTAVAIL.
      * Adds new function, redisAsyncConnectBindWithReuse(), letting
        clients enable this functionality.
      
      [Removed trailing whitespace in new header lines.]
      
      Closes #264
      7c4d2557
  17. 18 Sep, 2014 1 commit
  18. 10 Apr, 2014 2 commits
  19. 09 Apr, 2014 1 commit
  20. 08 Apr, 2014 3 commits
    • Matt Stancliff's avatar
      Add ability to bind source address on connect · 37d25a39
      Matt Stancliff authored
      Some environments require binding to specific source addresses instead
      of letting the system determine which IP a connection should originate
      from.
      
      Closes #233
      37d25a39
    • Matt Stancliff's avatar
      Stop redisCheckSocketError from more than checking · e35266e6
      Matt Stancliff authored
      redisCheckSocketError should only CheckSocketError and not
      close any misbehaving sockets.  If CheckSocketError discovers
      a problem, the caller will discover the contest is in ERR
      and will start destroying the context (which involves
      finalizing all callbacks (which may still be using
      fd for something, so we should not close fd until all
      callbacks have been told we are failing) and eventually
      close the fd in redisFree() immediately before the
      context is released).
      e35266e6
    • Matt Stancliff's avatar
      Remove possiblity of multiple close on same fd · 7f0c7a29
      Matt Stancliff authored
      With all the async connects and disconnects and error handling
      going on in hiredis, we need to centralize how we close our fd
      and set it so it doesn't get re-closed.  Prior to this commit,
      sometimes we'd close(fd), run an async error handler, then
      call close(fd) again.
      
      To stop multiple closes, we now set fd to -1 after we free it,
      but that requires not passing fd as an independent argument to
      functions.
      
      This commit moves all fd usage to c->fd.  Since the context
      has a fd field and all functions receive the context, it makes
      more sense to use the fd inside of c instead of passing along fd
      as an independent argument.
      
      Also, by only using c->fd, we can set c->fd after we close it to
      signify we shouldn't re-close the same fd again.
      
      This does change one semi-public interface function redisCheckSocketError()
      to only take (context) instead of (context, fd).  A search on github
      returned zero occasions of people using redisCheckSocketError()
      outside of net.{c,h} in hiredis itself.
      
      Commit inspired by the bug report at:
      https://groups.google.com/forum/#!topic/redis-db/mQm46XkIPOY
      
      Thanks go out to Thijs for trying high-frequency reconnects on
      a host that isn't there.
      
      Closes #230
      7f0c7a29
  21. 11 Jul, 2013 3 commits
  22. 07 May, 2013 1 commit
  23. 01 May, 2013 1 commit