- 26 Apr, 2024 1 commit
-
-
Jade Mattsson authored
* Proof-of-concept multi-type console support via stdio * Address crashes on linput's use of printf. On an empty line input, a C3 with UART console would panic while attempting to output the new Lua prompt. The backtrace shows a xQueueSemaphoreTake with uxItemSize==0 as the panic cause, deep inside the uart driver, invoked via vfs_uart and vfs_console layers, from printf. Similarly, the printf for outputting a backspace/erase sequence would also trigger a panic. This workaround (of not mixing fflush() with printf) is likely merely hiding a deeper issue, but it appears to be consistent. Plus, printf with no args and a user-supplied format string is a no-no and should be fixed anyway. * Work around IDF inconsistency with stdout buffering. * Increase console task stack size. Seems on Xtensa it ended up not being enough. * Switch to single-byte console reads. * Stop cheating and feed Lua from the right context. * Work around IDF buffering stdout even when told not to, on ACM consoles. * Initial build support for esp32c6. Plus fixup of module selection for a variety of targets. * Update github actions to node 20 versions. * Update github build to deal with Lua 5.3 being default. * Address fatal compiler warning. Newer IDF toolchain is stricter, and we'd apparently failed to build test the Lua-5.1 path for some time. * Initial build support for esp32h2. * Upgrade IDF to v5.1.3 * Fix left-over incorrect type in uzlib. * Avoid null pointer crashes when debugging startup. * Workaround for using wifi module on S2 with USB-CDC console. --------- Co-authored-by:
Jade Mattsson <github@frozenlogic.org>
-
- 30 Jan, 2024 1 commit
-
-
Johny Mattsson authored
Plenty of dependency adjustments, printf format specificier updates, FreeRTOS type and macro name modernisation, not to mention API changes. Still plenty of legacy/deprecated drivers in use which will need updating. The following features have been removed due to no longer being available from the IDF: - ADC hall effect sensor reading - Configuration of SD SPI host via sdmmc module (now must be done first via the spimaster module) - FAT partition selection on external SD cards; only the first FAT partition is supported by the IDF now On the other hand, the eth module now supports the following new chipsets: - KSZ8001 - KSZ8021 - KSZ8031 - KSZ8051 - KSZ8061 - KSZ8091 - Possibly additional models in the LAN87xx series (the IDF docs aren't clear on precisely which models are handled) Further, the sdmmc module is now available on the ESP32-S3 as well.
-
- 11 Aug, 2021 1 commit
-
-
Johny Mattsson authored
The uzlib and parts of Lua had to be switched over to use the C standard int types, as their custom typedefs conflicted with RISC-V toolchain provided typedefs. UART console driver updated to do less direct register meddling and use the IDF uart driver interface for setup. Still using our own ISR rather than the default driver ISR. Down the line we might want to investigate whether the IDF ISR would be a better fit. Lua C modules have been split into common and ESP32/ESP32-S specific ones. In the future there might also be ESP32-C3 specific modules, which would go into components/modules-esp32c3 at that point. Our old automatic fixup of flash size has been discarded as it interferes with the checksumming done by the ROM loader and results in unbootable systems. The IDF has already taken on this work via the ESPTOOL_FLASHSIZE_DETECT option, which handles this situation properly.
-
- 26 Jul, 2021 1 commit
-
-
Johny Mattsson authored
-
- 19 Jul, 2019 1 commit
-
-
Johny Mattsson authored
* Move task_post() into IRAM so it can be used by IRAM'd ISRs. * Don't leave crud on stack on pcall error.
-
- 14 Jul, 2019 1 commit
-
-
Johny Mattsson authored
To avoid races between the lwIP callbacks (lwIP RTOS task) and the Lua handlers (LVM RTOS task), the data flow and ownership has been simplified and cleaned up. lwIP callbacks now have no visibility of the userdata struct. They are limited to creating small event objects and task_post()ing them over to the LVM "thread", passing ownership in doing so. The shared identifier then becomes the struct netconn*. On the LVM side, we keep a linked list of active userdata objects. This allows us to retrieve the correct userdata when we get an event with a netconn pointer. Because this list is only ever used within the LVM task, no locking is necessary. The old approach of stashing a userdata pointer into the 'socket' field on the netconn has been removed entirely, as this was both not thread/RTOS-task safe, and also interfered with the IDFs internal use of the socket field (even when using only the netconn layer). As an added benefit, this removed the need for all the SYS_ARCH_PROTECT() locking stuff. The need to track receive events before the corresponding userdata object has been established has been removed by virtue of not reordering the "accept" and the "recv" events any more (previously accepts were posted with medium priority, while the receives where high priority, leading to the observed reordering and associated headaches). The workaround for IDF issue 784 has been removed as it is now not needed and is in fact directly harmful as it results in a double-free. Yay for getting rid of old workarounds! DNS resolution code paths were merged for the two instances of "socket" initiated resolves (connect/dns functions). Also fixed an instance of using a stack variable for receiving the resolved IP address, with said variable going out of scope before the DNS resolution necessarily completed (hello, memory corruption!). Where possible, moved to use the Lua allocator rather than plain malloc. Finally, the NodeMCU task posting mechanism got a polish and an adjustment. Given all the Bad(tm) that tends to happen if something fails task posting, I went through a couple of iterations on how to avoid that. Alas, the preferred solution of blocking non-LVM RTOS tasks until a slot is free turned out to not be viable, as this easily resulted in deadlocks with the lwIP stack. After much deliberation I settled on increasing the number of available queue slots for the task_post() mechanism, but in the interest of user control also now made it user configurable via Kconfig.
-
- 20 Sep, 2016 1 commit
-
-
Johny Mattsson authored
RTOS driver evicted as it did not play nice with stdio etc. Implemented a minimal driver to fully support Lua console on UART0. Output on UART0 done via stdout (provided by the IDF). Input and setup handled via driver_console/console.c. In addition to the direct input function console_getc(), the driver also registers in the syscall tables to enable regular stdio input functions to work (yay!). The Lua VM is still using the direct interface since it's less overhead, but does also work when going through stdin/fd 0. Auto-bauding on the console is not yet functional; revisit when the UART docs are available. Module registration/linking/enabling moved over to be Kconfig based. See updates to base_nodemcu/include/module.h and base_nodemcu/Kconfig for details. The sdk-overrides directory/approach is no longer used. The IDF is simply too different to the old RTOS SDK - we need to adapt our code directly instead. Everything in app/ is now unused, and will need to be gradually migrated into components/ though it is probably better to migrate straight from the latest dev branch.
-
- 16 Sep, 2016 1 commit
-
-
Johny Mattsson authored
Currently the UART driver break boot (or at least output).
-
- 09 Jun, 2016 1 commit
-
-
Johny Mattsson authored
A fair bit of reshuffling with include paths and overrides was necessary, as the two RTOS SDKs (ESP8266 and ESP32) don't have the same header structure (or even libraries for that matter). Uses the xtensa-esp108-elf toolchain to build. Completely untested beyond linking, as I still can't flash the ESP32 module I have :( I'd be most surprised if it does anything useful at this point considering I've spent almost no time on the linker script or UART setup. Anything using espconn has been ifdef'd out since espconn is not (and probably will not be) available. Notably this includes the entire net module as well as coap, mqtt and enduser_setup. Many (most?) hardware bus drivers and related modules are also ifdef'd out for now due to hardware differences. Functions surrounding sleep, rtc and RF modes have also been hit by the ifdef hammer. Grep'ing for __ESP8266__ and/or FIXME is a quick way of finding these places. With time I hope all of these will be reinstated.
-
- 31 May, 2016 1 commit
-
-
Johny Mattsson authored
-
- 30 May, 2016 1 commit
-
-
Johny Mattsson authored
Uart driver currently disabled as it's not (yet) compatible with RTOS. Running Lua task with excessive stack to avoid smashing it; need to work out what's using so much stack space. Changed some flash reading functions to not attempt to drop an entire 4k flash page onto the stack. Ensure the task pump doesn't attempt to retrieve from uninitialised queues.
-
- 24 May, 2016 2 commits
-
-
Johny Mattsson authored
Not yet hooked up to an RTOS task, however.
-
Johny Mattsson authored
This compiles, links, and starts the RTOS without crashing and burning. Lua environment does not yet start due to the different task architecture. Known pain points: - task implementation needs to be rewritten for RTOS (next up on my TODO) - secure espconn does not exist, all secure espconn stuff has been #if 0'd - lwip now built from within the RTOS SDK, but does not appear to include MDNS support. Investigation needed. - there is no access to FRC1 NMI, not sure if we ever actually used that however. Also #if 0'd out for now. - new timing constraints introduced by the RTOS, all use of ets_delay_us() and os_delay_us() needs to be reviewed (the tsl2561 driver in particular). - even more confusion with ets_ vs os_ vs c_ vs non-prefixed versions. In the long run everything should be switched to non-prefixed versions. - system_set_os_print() not available, needs to be reimplemented - all the RTOS rodata is loaded into RAM, as it apparently uses some constants while the flash isn't mapped, so our exception handler can't work its magic. This should be narrowed down to the minimum possible at some point. - with each task having its own stack in RTOS, we probably need change flash-page buffers from the stack to the heap in a bunch of places. A single, shared, page buffer *might* be possible if we limit ourselves to running NodeMCU in a single task. - there's a ton of junk in the sdk-overrides now; over time the core code should be updated to not need those shims
-
- 17 Feb, 2016 1 commit
-
-
TerryE authored
As with the last commit this rolls up the follwowing, but include the various review comments on the PR. - **Documentation changes**. I've added the taks FAQ as a stub new Extension developer FAQ, and split the old FAQ into a Lua Developer FAQ and a Hardware FAQ. - **Tasking I/F**. New `app/task/Makefile`, `app/task/task.c`, `app/include/task/task.h` and `app/Makefile` as per previous commit. Cascade changes to `app/driver/uart.c`, `app/include/driver/uart.h`, `app/user/user_main.c` and `app/modules/node.c` - **GPIO Rework** to `app/modules/gpio.c` and `pin_map.[hc]`, `platform.[hc]` in `app/platform` - **Other Optimisations** Move the `platform_*_exists()` from `app/platform/common.c` to static inline declarations in `platform.h` as this generates faster, smaller code. Move lgc.a routines out of iram0.
-