- 21 May, 2024 1 commit
-
-
Jade Mattsson authored
With the switch to use the IDF's stdin for feeding the Lua VM, we unintentionally lost the ability to use uart.on('data') on the console uart. This is since we no longer install the nodemcu uart driver on said uart. In order to resolve this shortcoming, this commit refactors the uart.on('data') delimiter handling and moves it away from platform.c into uart.c where it really belongs. A new function, uart_feed_data(), is introduced, which is used both by the nodemcu uart driver task as well as the nodemcu console driver task (assuming the console is in fact a uart). The linebuffer allocation/freeing is still in response to uart.start()/uart.stop(), but it is now in uart.c rather than platform.c. The whole uart integration is still too tightly coupled between the platform component and the module component's uart.c, but this makes it slightly better at least.
-
- 26 Apr, 2024 1 commit
-
-
Jade Mattsson authored
* Proof-of-concept multi-type console support via stdio * Address crashes on linput's use of printf. On an empty line input, a C3 with UART console would panic while attempting to output the new Lua prompt. The backtrace shows a xQueueSemaphoreTake with uxItemSize==0 as the panic cause, deep inside the uart driver, invoked via vfs_uart and vfs_console layers, from printf. Similarly, the printf for outputting a backspace/erase sequence would also trigger a panic. This workaround (of not mixing fflush() with printf) is likely merely hiding a deeper issue, but it appears to be consistent. Plus, printf with no args and a user-supplied format string is a no-no and should be fixed anyway. * Work around IDF inconsistency with stdout buffering. * Increase console task stack size. Seems on Xtensa it ended up not being enough. * Switch to single-byte console reads. * Stop cheating and feed Lua from the right context. * Work around IDF buffering stdout even when told not to, on ACM consoles. * Initial build support for esp32c6. Plus fixup of module selection for a variety of targets. * Update github actions to node 20 versions. * Update github build to deal with Lua 5.3 being default. * Address fatal compiler warning. Newer IDF toolchain is stricter, and we'd apparently failed to build test the Lua-5.1 path for some time. * Initial build support for esp32h2. * Upgrade IDF to v5.1.3 * Fix left-over incorrect type in uzlib. * Avoid null pointer crashes when debugging startup. * Workaround for using wifi module on S2 with USB-CDC console. --------- Co-authored-by:
Jade Mattsson <github@frozenlogic.org>
-
- 30 Jan, 2024 1 commit
-
-
Johny Mattsson authored
Plenty of dependency adjustments, printf format specificier updates, FreeRTOS type and macro name modernisation, not to mention API changes. Still plenty of legacy/deprecated drivers in use which will need updating. The following features have been removed due to no longer being available from the IDF: - ADC hall effect sensor reading - Configuration of SD SPI host via sdmmc module (now must be done first via the spimaster module) - FAT partition selection on external SD cards; only the first FAT partition is supported by the IDF now On the other hand, the eth module now supports the following new chipsets: - KSZ8001 - KSZ8021 - KSZ8031 - KSZ8051 - KSZ8061 - KSZ8091 - Possibly additional models in the LAN87xx series (the IDF docs aren't clear on precisely which models are handled) Further, the sdmmc module is now available on the ESP32-S3 as well.
-
- 20 Oct, 2021 1 commit
-
-
Johny Mattsson authored
The IDF-provided VFS resolves several issues: - The IDF components having a different view of the (virtual) file system compared to the Lua environment. - RTOS task/thread safety. Our legacy VFS was only ever safe to use from the LVM thread, which limited its usability. Upgrading it would have effectively required a reimplementation of the IDF VFS, which would have been a bigger task with larger on-going maintenance issues. - We're no longer needing to maintain our own SPIFFS component. - We're no longer needing to maintain our own FATFS component. - The legacy of the 8266's lack of standard C interface to the file system is no longer holding us back, meaning that we can use the standard Lua `io` module rather than the cobbled-together swiss army knife also known as the file module. Of course, the downside is that we'll either have to declare a backwards breakage in regard to the file module, or provide a Lua shim for the old functions, where applicable. Also included is some necessary integer type fixups in unrelated code, which apparently had depended on some non-standard types in either the SPIFFS or FATFS headers. A memory leak issue in the sdmmc module was also found and fixed while said module got switched over to the Espressif VFS. Module documentation has been updated to match the new reality (and I discovered in some places it wasn't even matching the old reality).
-
- 23 Aug, 2021 1 commit
-
-
Johny Mattsson authored
The IDF provides all we need these days, and the old driver was just needlessly conflicting with the IDF settings and setup. This also simplifies our uart input path as we no longer need to duplicate the raw byte handling for when "run_input" is false.
-
- 21 Aug, 2021 1 commit
-
-
Johny Mattsson authored
Changes have been kept to a minimum, but a serious chunk of work was needed to move from 8266isms to IDFisms. Some things got refactored into components/lua/common, in particular the LFS location awareness. As part of this work I also evicted our partition table manipulation code, as with the current IDF it kept breaking checksums and rendering things unbootable, which is the opposite of helpful (which was the original intent behind it). The uart module got relocated from base_nodemcu to the modules component properly, after I worked out how to force its inclusion using Kconfig alone.
-
- 11 Aug, 2021 1 commit
-
-
Johny Mattsson authored
The uzlib and parts of Lua had to be switched over to use the C standard int types, as their custom typedefs conflicted with RISC-V toolchain provided typedefs. UART console driver updated to do less direct register meddling and use the IDF uart driver interface for setup. Still using our own ISR rather than the default driver ISR. Down the line we might want to investigate whether the IDF ISR would be a better fit. Lua C modules have been split into common and ESP32/ESP32-S specific ones. In the future there might also be ESP32-C3 specific modules, which would go into components/modules-esp32c3 at that point. Our old automatic fixup of flash size has been discarded as it interferes with the checksumming done by the ROM loader and results in unbootable systems. The IDF has already taken on this work via the ESPTOOL_FLASHSIZE_DETECT option, which handles this situation properly.
-
- 19 Jul, 2021 1 commit
-
-
Johny Mattsson authored
Some parts dry-coded in the disabled modules; to be fixed when sorting out the deprecated/removed APIs used in said modules. Still untested beyond compile/linking.
-
- 15 Jul, 2021 1 commit
-
-
Johny Mattsson authored
Yet to come: - part 2: dealing with deprecated and removed APIs - part 3: making it actually work again
-
- 03 Aug, 2020 1 commit
-
-
David Thornley authored
Manifests as multiple definition of esp_event_send during compilation, as bthci triggers inclusion of `event_loop.c`. Also improved lbth_init() to support BTDM or BLE_ONLY controller modes.
-
- 14 Jul, 2019 1 commit
-
-
Johny Mattsson authored
To avoid races between the lwIP callbacks (lwIP RTOS task) and the Lua handlers (LVM RTOS task), the data flow and ownership has been simplified and cleaned up. lwIP callbacks now have no visibility of the userdata struct. They are limited to creating small event objects and task_post()ing them over to the LVM "thread", passing ownership in doing so. The shared identifier then becomes the struct netconn*. On the LVM side, we keep a linked list of active userdata objects. This allows us to retrieve the correct userdata when we get an event with a netconn pointer. Because this list is only ever used within the LVM task, no locking is necessary. The old approach of stashing a userdata pointer into the 'socket' field on the netconn has been removed entirely, as this was both not thread/RTOS-task safe, and also interfered with the IDFs internal use of the socket field (even when using only the netconn layer). As an added benefit, this removed the need for all the SYS_ARCH_PROTECT() locking stuff. The need to track receive events before the corresponding userdata object has been established has been removed by virtue of not reordering the "accept" and the "recv" events any more (previously accepts were posted with medium priority, while the receives where high priority, leading to the observed reordering and associated headaches). The workaround for IDF issue 784 has been removed as it is now not needed and is in fact directly harmful as it results in a double-free. Yay for getting rid of old workarounds! DNS resolution code paths were merged for the two instances of "socket" initiated resolves (connect/dns functions). Also fixed an instance of using a stack variable for receiving the resolved IP address, with said variable going out of scope before the DNS resolution necessarily completed (hello, memory corruption!). Where possible, moved to use the Lua allocator rather than plain malloc. Finally, the NodeMCU task posting mechanism got a polish and an adjustment. Given all the Bad(tm) that tends to happen if something fails task posting, I went through a couple of iterations on how to avoid that. Alas, the preferred solution of blocking non-LVM RTOS tasks until a slot is free turned out to not be viable, as this easily resulted in deadlocks with the lwIP stack. After much deliberation I settled on increasing the number of available queue slots for the task_post() mechanism, but in the interest of user control also now made it user configurable via Kconfig.
-
- 07 Oct, 2018 1 commit
-
-
tomsci authored
* Set stdout to unbuffered This fixes issue #2507 esp32 serial console doesn't show output until enter pressed. * Moved setvbuf call to app_main immediately after console_init
-
- 06 Apr, 2017 1 commit
-
-
devsaurus authored
-
- 27 Nov, 2016 1 commit
-
-
Johny Mattsson authored
-
- 12 Nov, 2016 1 commit
-
-
Johny Mattsson authored
-
- 03 Oct, 2016 1 commit
-
-
Johny Mattsson authored
We're already in the right context, there is no point posting back the Lua start, we can do it right then and there instead.
-
- 29 Sep, 2016 1 commit
-
-
Johny Mattsson authored
-
- 28 Sep, 2016 1 commit
-
-
Johny Mattsson authored
-
- 27 Sep, 2016 1 commit
-
-
Johny Mattsson authored
Modules can now subscribe to ESP system events via the new NODEMCU_ESP_EVENT() macro. See nodemcu_esp_event.h for details.
-
- 23 Sep, 2016 1 commit
-
-
Johny Mattsson authored
No longer limited to the default 2MB.
-
- 22 Sep, 2016 2 commits
-
-
Johny Mattsson authored
Now uses the designated partition (type 0xC2, 0x00) unconditionally.
-
Johny Mattsson authored
It would appear my ESP3212 only has a 2MB flash chip despite the bootloader saying 4MB.
-
- 21 Sep, 2016 1 commit
-
-
Johny Mattsson authored
Also included the recent LVM fix. Platform flash layer not yet functional.
-
- 20 Sep, 2016 1 commit
-
-
Johny Mattsson authored
RTOS driver evicted as it did not play nice with stdio etc. Implemented a minimal driver to fully support Lua console on UART0. Output on UART0 done via stdout (provided by the IDF). Input and setup handled via driver_console/console.c. In addition to the direct input function console_getc(), the driver also registers in the syscall tables to enable regular stdio input functions to work (yay!). The Lua VM is still using the direct interface since it's less overhead, but does also work when going through stdin/fd 0. Auto-bauding on the console is not yet functional; revisit when the UART docs are available. Module registration/linking/enabling moved over to be Kconfig based. See updates to base_nodemcu/include/module.h and base_nodemcu/Kconfig for details. The sdk-overrides directory/approach is no longer used. The IDF is simply too different to the old RTOS SDK - we need to adapt our code directly instead. Everything in app/ is now unused, and will need to be gradually migrated into components/ though it is probably better to migrate straight from the latest dev branch.
-
- 16 Sep, 2016 1 commit
-
-
Johny Mattsson authored
Currently the UART driver break boot (or at least output).
-
- 23 Jun, 2016 1 commit
-
-
Johny Mattsson authored
New driver is a three-way merger between Espressif's esp8266-rtos-sdk example driver, Espressif's esp32-rtos-sdk not-example driver, and the previous NodeMCU driver, plus some general clean-ups. Basic interactivity is now available on the ESP32!
-
- 22 Jun, 2016 1 commit
-
-
Johny Mattsson authored
Running without interrupt vectors not considered all that useful... Disabled flash-size-byte-setting and SPIFFS formatting on ESP32, for now at least, as both of these appeared to corrupt the flash and prevent subsequent boots. Disabled UART init on ESP32 until the driver gets updated. This now gets us to a banner on ESP32, but not yet a prompt.
-
- 09 Jun, 2016 1 commit
-
-
Johny Mattsson authored
A fair bit of reshuffling with include paths and overrides was necessary, as the two RTOS SDKs (ESP8266 and ESP32) don't have the same header structure (or even libraries for that matter). Uses the xtensa-esp108-elf toolchain to build. Completely untested beyond linking, as I still can't flash the ESP32 module I have :( I'd be most surprised if it does anything useful at this point considering I've spent almost no time on the linker script or UART setup. Anything using espconn has been ifdef'd out since espconn is not (and probably will not be) available. Notably this includes the entire net module as well as coap, mqtt and enduser_setup. Many (most?) hardware bus drivers and related modules are also ifdef'd out for now due to hardware differences. Functions surrounding sleep, rtc and RF modes have also been hit by the ifdef hammer. Grep'ing for __ESP8266__ and/or FIXME is a quick way of finding these places. With time I hope all of these will be reinstated.
-
- 02 Jun, 2016 1 commit
-
-
Johny Mattsson authored
-
- 01 Jun, 2016 1 commit
-
-
Johny Mattsson authored
The os_timer callback is executed from task rtT, prio 14, so they preempt the Lua environment whenever they fire. Ideally we should be using the RTOS timers instead, which run at prio 2 and thus would be more suited for our uses.
-
- 31 May, 2016 1 commit
-
-
Johny Mattsson authored
-
- 30 May, 2016 1 commit
-
-
Johny Mattsson authored
Uart driver currently disabled as it's not (yet) compatible with RTOS. Running Lua task with excessive stack to avoid smashing it; need to work out what's using so much stack space. Changed some flash reading functions to not attempt to drop an entire 4k flash page onto the stack. Ensure the task pump doesn't attempt to retrieve from uninitialised queues.
-
- 26 May, 2016 4 commits
-
-
Johny Mattsson authored
c_strtod and c_getenv are kept since strtod doesn't appear in the SDK's libc, and we want our own c_getenv to initialize the Lua main anyway.
-
Johny Mattsson authored
-
Johny Mattsson authored
With a working exception handler all of the RTOS-SDK bits seem to be happy too. So far.
-
Johny Mattsson authored
Incidentally now also a whole lot faster.
-
- 24 May, 2016 1 commit
-
-
Johny Mattsson authored
Not yet hooked up to an RTOS task, however.
-
- 18 May, 2016 1 commit
-
-
Johny Mattsson authored
- Stop fighting against the SDK in terms of owning/writing the init_data block. NodeMCU included a default init_data block because originally the SDK did not, but by now it's not needed. - Expose a way to reconfigure the ADC mode from Lua land. With most people using the cloud builder and not able to change the #define for byte 107 this has been a pain point. - Less confusion about which init_data has been used. Lua code can now simply state what mode it wants the ADC to be in, and not worry about the rest of the init_data complexities such as the init_data changing location due to flashing with wrong flash_size setting, or doing/not doing a chip-erase before loading new NodeMCU firmware.
-
- 23 Mar, 2016 1 commit
-
-
devsaurus authored
-
- 20 Mar, 2016 1 commit
-
-
philip authored
-