- 05 Jan, 2021 1 commit
-
-
Nathaniel Wesley Filardo authored
* mqtt: remove concept of connection timeout Just rely on the network stack to tell us when things have gone south. * mqtt: remove write-only mqtt_state.port field * mqtt: drop useless conditional * mqtt: decouple message sent flag from timer * mqtt: reconnect callback does not need to hang up The network stack has certainly done that for us at this point. Similarly, since we're about to call mqtt_socket_disconnected, don't bother unregistering the timer here, either. * mqtt: don't tick once per second Set the timer for the duration of the wait and cancel it on the other side. * mqtt: defer message queue destruction to _disconnect We're going to want to publish a disconnect message for real, so doing this in _close does no one any favors * mqtt: miscellaneous cleanups No functional change intended * mqtt: close() should send disconnect message for real This means waiting for _sent() to fire again before telling the network stack to disconnect. * mqtt: tidy connect and dns - Push the self-ref to after all allocations and error returns - Don't try to extract IPv4 from the domain string ourselves, let the resolver, since it can - Don't try to connect to localhost. That can't possibly work. * mqtt: common up some callback invocations * mqtt: don't retransmit messages on timeout There's no point in retransmitting messages on timeout; the network stack will be trying to do it for us anyway. * mqtt: remove unnecessary NULL udata checks * mqtt: hold strings in Lua, not C Eliminates a host of C-side allocations. While here, move the rest of the mqtt_connect_info structure out to its own thing, and pack some flags using a bitfield. * mqtt: mqtt_socket_on use lua_checkoption * mqtt: slightly augment debug messages These changes have made some debugging ever so slightly easier.
-
- 09 Jun, 2020 4 commits
-
-
Nathaniel Wesley Filardo authored
* espconn: remove unused espconn code, take 1 This is the easiest part of https://github.com/nodemcu/nodemcu-firmware/issues/3004 . It removes a bunch of functions that were never called in our tree. * espconn: De-orbit espconn_gethostbyname Further work on https://github.com/nodemcu/nodemcu-firmware/issues/3004 While here, remove `mqtt`'s charming DNS-retry logic (which is neither shared with nor duplicated in other modules) and update its :connect() return value behavior and documentation. * espconn: remove scary global pktinfo A write-only global! How about that. * net: remove deprecated methods All the TLS stuff moved over there a long time ago, and net_createUDPSocket should just do what it says on the tin. * espconn_secure: remove ESPCONN_SERVER support We can barely function as a TLS client; being a TLS server seems like a real stretch. This code was never called from Lua anyway. * espconn_secure: more code rem...
-
Marcel Stör authored
-
Nathaniel Wesley Filardo authored
* mqtt: expose "connfail" callback via :on() This makes it just like all the other callbacks in the module and is a revision of behavior called out in https://github.com/nodemcu/nodemcu-firmware/pull/2967 * mqtt: clarify when puback callback fires * mqtt: Don't reference stack buffers from the heap The confusingly-named "mqtt_connection_t" object is just a triple of - a serialized mqtt message pointer and length - a buffer pointer (to which the above can be written) - a message identifier The last of these must be passed around the mqtt state machine, but the first two are very local and the buffer is always sourced from the C stack. Unfortunately, because the entire structure is persisted in the heap, some callers assume that they can always use the structure without reinitialization (see mqtt_socket_close), which will trash the C stack. Sever the pairing between message id and local state, punt the local state entirely out of the heap, and rename things to be less confusing.
-
Johan Ström authored
-
- 04 Aug, 2019 1 commit
-
-
Nathaniel Wesley Filardo authored
We just don't have the memory to be a real TLS client on the 8266. Put that in a big box and point at it from the http and mqtt modules; others may also wish to give reference.
-
- 16 Jul, 2019 1 commit
-
-
Nathaniel Wesley Filardo authored
* mqtt:connect() secure parameter should be boolean Continue to honor the old 0/1 values, but make them undocumented and add a deprecation warning to the code and docs. Eventually, this should go away. * mqtt: rip out deprecated autoreconnect * mqtt: expose all the callbacks via :on
-
- 17 Feb, 2019 1 commit
-
-
sergio authored
-
- 13 Jan, 2019 1 commit
-
-
Marcel Stör authored
Drop support for localized content, #2213 Restructure some content to match more closely what we have in master, #2542
-
- 30 Nov, 2018 1 commit
-
-
Johan Ström authored
* MQTT: handle large/chunked/fragmented messages properly If a message spans multiple TCP packets it must be buffered before delivered to LUA. Prior code did not do this at all, so this "patch" really adds proper handling of fragmented MQTT packets. This could also occur if multiple small messages was sent in a single TCP packet, and the last message did not completely fit in that packet. Introduces a new option to the mqtt.Client constructor: max_publish_length which defaults to 1024 Introduces a new 'overflow' callback. Fixes issue #2308 and proper fix for PR #2544. * mqtt.md: clarified heap allocation * mqtt: ensure ack is sent for overflowed publish If QoS is used we should still acknowledge that we received it, or server might retransmit it later.
-
- 05 Oct, 2017 1 commit
-
-
dbaumgarten authored
-
- 22 Aug, 2017 1 commit
-
-
Marcel Stör authored
Fixes #2039
-
- 04 Apr, 2017 1 commit
-
-
Philip Gladstone authored
* Fix the error callback from not being called sometimes * Moved the setting of the reconnect status to after the connack is recevied * Increase the irom0_seg size * Updated the documentation * Make it clearer that autoreconnect is deprecated
-
- 12 Feb, 2017 1 commit
-
-
Marcel Stör authored
-
- 15 Jan, 2017 1 commit
-
-
Alexis Lothoré authored
-
- 01 Jun, 2016 1 commit
-
-
Marcel Stör authored
-
- 02 Apr, 2016 1 commit
-
-
Rick Lettow authored
unsubscribe() and publish() callback functions.
-
- 20 Mar, 2016 1 commit
-
-
philip authored
-
- 07 Mar, 2016 1 commit
-
-
jfollas authored
- per @pjsg's suggestion
-
- 06 Mar, 2016 2 commits
-
-
jfollas authored
- Process the CONNACK message received from the broker after Connect - Provide feedback to Lua via failure callback on client:connect() - Also provide failure information for other situations not covered by CONNACK
-
Marcel Stör authored
-
- 06 Feb, 2016 1 commit
-
-
Marcel Stör authored
Fixes #996
-
- 30 Jan, 2016 1 commit
-
-
Arnim Läuger authored
-
- 29 Jan, 2016 1 commit
-
-
Arnim Läuger authored
-
- 28 Jan, 2016 2 commits
- 26 Jan, 2016 1 commit
-
-
Arnim Läuger authored
-
- 17 Jan, 2016 1 commit
-
-
Marcel Stör authored
-
- 10 Jan, 2016 1 commit
-
-
Marcel Stör authored
-