• antirez's avatar
    Geo: big refactoring of geo.c, zset.[ch] removed. · 0b931390
    antirez authored
    This commit simplifies the implementation in a few ways:
    
    1. zsetScore implementation improved a bit and moved into t_zset.c where
       is now also used to implement the ZSCORE command.
    
    2. Range extraction from the sorted set remains a separated
       implementation from the one in t_zset.c, but was hyper-specialized in
       order to avoid accumulating results into a list and remove the ones
       outside the radius.
    
    3. A new type is introduced: geoArray, which can accumulate geoPoint
       structures in a vector with power of two expansion policy. This is
       useful since we have to call qsort() against it before returning the
       result to the user.
    
    4. As a result of 1, 2, 3, the two files zset.c and zset.h are now
       removed, including the function to merge two lists (now handled with
       functions that can add elements to existing geoArray arrays) and
       the machinery used in order to pass zset results.
    
    5. geoPoint structure simplified because of the general code structure
       simplification, so we no longer need to take references to objects.
    
    6. Not counting the JSON removal the refactoring removes 200 lines of
       code for the same functionalities, with a simpler to read
       implementation.
    
    7. GEORADIUS is now 2.5 times faster testing with 10k elements and a
       radius resulting in 124 elements returned. However this is mostly a
       side effect of the refactoring and simplification. More speed gains
       can be achieved by trying to optimize the code.
    0b931390
Makefile 7.85 KB