• Oran Agra's avatar
    Prevent LCS from allocating temp memory over proto-max-bulk-len (#9817) · 14176484
    Oran Agra authored
    LCS can allocate immense amount of memory (sizes of two inputs multiplied by each other).
    In the past this caused some possible security issues due to overflows, which we solved
    and also added use of `trymalloc` to return "Insufficient memory" instead of OOM panic zmalloc.
    
    But in case overcommit is enabled, it could be that we won't get the OOM panic, and zmalloc
    will succeed, and then we can get OOM killed by the kernel.
    
    The solution here is to prevent LCS from allocating transient memory that's bigger than
    `proto-max-bulk-len` config.
    This config is not directly related to transient memory, but using a hard coded value ad well as
    introducing a specific config seems wrong.
    
    This comes to solve an error in the corrupt-dump-fuzzer test that started in the daily CI see #9799
    14176484
t_string.c 33.3 KB