• Z. Liu's avatar
    Add 'set-proc-title' config so that this mechanism can be disabled (#3623) · 17b34c73
    Z. Liu authored
    
    
    if option `set-proc-title' is no, then do nothing for proc title.
    
    The reason has been explained long ago, see following:
    
    We update redis to 2.8.8, then found there are some side effect when
    redis always change the process title.
    
    We run several slave instance on one computer, and all these salves
    listen on unix socket only, then ps will show:
    
      1 S redis 18036 1 0 80 0 - 56130 ep_pol 14:02 ? 00:00:31 /usr/sbin/redis-server *:0
      1 S redis 23949 1 0 80 0 - 11074 ep_pol 15:41 ? 00:00:00 /usr/sbin/redis-server *:0
    
    for redis 2.6 the output of ps is like following:
    
      1 S redis 18036 1 0 80 0 - 56130 ep_pol 14:02 ? 00:00:31 /usr/sbin/redis-server /etc/redis/a.conf
      1 S redis 23949 1 0 80 0 - 11074 ep_pol 15:41 ? 00:00:00 /usr/sbin/redis-server /etc/redis/b.conf
    
    Later is more informational in our case. The situation
    is worse when we manage the config and process running
    state by salt. Salt check the process by running "ps |
    grep SIG" (for Gentoo System) to check the running
    state, where SIG is the string to search for when
    looking for the service process with ps. Previously, we
    define sig as "/usr/sbin/redis-server
    /etc/redis/a.conf". Since the ps output is identical for
    our case, so we have no way to check the state of
    specified redis instance.
    
    So, for our case, we prefer the old behavior, i.e, do
    not change the process title for the main redis process.
    Or add an option such as "set-proc-title [yes|no]" to
    control this behavior.
    Co-authored-by: default avatarYossi Gottlieb <yossigo@gmail.com>
    Co-authored-by: default avatarOran Agra <oran@redislabs.com>
    17b34c73
redis.conf 89.3 KB