• Qu Chen's avatar
    Unlock cluster config file upon server shutdown. (#10912) · 33b7ff38
    Qu Chen authored
    Currently in cluster mode, Redis process locks the cluster config file when
    starting up and holds the lock for the entire lifetime of the process.
    When the server shuts down, it doesn't explicitly release the lock on the
    cluster config file. We noticed a problem with restart testing that if you shut down
    a very large redis-server process (i.e. with several hundred GB of data stored),
    it takes the OS a while to free the resources and unlock the cluster config file.
    So if we immediately try to restart the redis server process, it might fail to acquire
    the lock on the cluster config file and fail to come up.
    
    This fix explicitly releases the lock on the cluster config file upon a shutdown rather
    than relying on the OS to release the lock, which is a cleaner and safer approach to
    free up resources acquired. 
    33b7ff38
server.c 271 KB