• Binbin's avatar
    Fix crash when running rebalance command in a mixed cluster of 7.0 and 7.2 (#12604) · 7f6de086
    Binbin authored
    In #10536, we introduced the assert, some older versions of servers
    (like 7.0) doesn't gossip shard_id, so we will not add the node to
    cluster->shards, and node->shard_id is filled in randomly and may not
    be found here.
    
    It causes that if we add a 7.2 node to a 7.0 cluster and allocate slots
    to the 7.2 node, the 7.2 node will crash when it hits this assert. Somehow
    like #12538.
    
    In this PR, we remove the assert and replace it with an unconditional removal.
    
    (cherry picked from commit e5ef1613)
    7f6de086
cluster.c 302 KB