• antirez's avatar
    Fix ae.c when a timer finalizerProc adds an event. · 8ac7af1c
    antirez authored
    While this feature is not used by Redis, ae.c implements the ability for
    a timer to call a finalizer callback when an timer event is deleted.
    This feature was bugged since the start, and because it was never used
    we never noticed a problem. However Anthony LaTorre was using the same
    library in order to implement a different system: he found a bug that he
    describes as follows, and which he fixed with the patch in this commit,
    sent me by private email:
    
        --- Anthony email ---
    
    've found one bug in the current implementation of the timed events.
    It's possible to lose track of a timed event if an event is added in
    the finalizerProc of another event.
    
    For example, suppose you start off with three timed events 1, 2, and
    3. Then the linked list looks like:
    
    3 -> 2 -> 1
    
    Then, you run processTimeEvents and events 2 and 3 finish, so now the
    list looks like:
    
    -1 -> -1 -> 2
    
    Now, on the next iteration of processTimeEvents it starts by deleting
    the first event, an...
    8ac7af1c
ae.h 5.21 KB