• Jokea's avatar
    Force expire all timer events when system clock skew is detected. · b7b2a1cc
    Jokea authored
    When system time changes back, the timer will not worker properly
    hence some core functionality of redis will stop working(e.g. replication,
    bgsave, etc). See issue #633 for details.
    
    The patch saves the previous time and when a system clock skew is detected,
    it will force expire all timers.
    
    Modiifed by @antirez: the previous time was moved into the eventLoop
    structure to make sure the library is still thread safe as long as you
    use different event loops into different threads (otherwise you need
    some synchronization). More comments added about the reasoning at the
    base of the patch, that's worth reporting here:
    
    /* If the system clock is moved to the future, and then set back to the
     * right value, time events may be delayed in a random way. Often this
     * means that scheduled operations will not be performed soon enough.
     *
     * Here we try to detect system clock skews, and force all the time
     * events to be processed ASAP when this happens: the idea is that
     * processing events earlier is less dangerous than delaying them
     * indefinitely, and practice suggests it is. */
    b7b2a1cc
ae.c 14.3 KB