• Binbin's avatar
    Increase the threshold of the AOF loading defrag test (#11871) · bfe50a30
    Binbin authored
    This test is very sensitive and fragile. It often fails in Daily,
    in most cases, it failed in test-ubuntu-32bit (the AOF loading one),
    with the range in (31, 40):
    ```
    [err]: Active defrag in tests/unit/memefficiency.tcl
    Expected 38 <= 30 (context: type eval line 113 cmd {assert {$max_latency <= 30}} proc ::test)
    ```
    
    The AOF loading part isn't tightly fixed to the cron hz. It calls
    processEventsWhileBlocked once in every 1024 command calls.
    ```
            /* Serve the clients from time to time */
            if (!(loops++ % 1024)) {
                off_t progress_delta = ftello(fp) - last_progress_report_size;
                loadingIncrProgress(progress_delta);
                last_progress_report_size += progress_delta;
                processEventsWhileBlocked();
                processModuleLoadingProgressEvent(1);
            }
    ```
    
    In this case, we can either decrease the 1024 or increase the
    threshold of just the AOF part of that test. Considering the test
    machines are sometimes slow, and all sort of quirks could happen
    (which do not indicate a bug), and we've already set to 30, we suppose
    we can set it a little bit higher, set it to 40. We can have this instead of
    adding another testing config (we can add it when we really need it).
    
    Fixes #11868
    bfe50a30
memefficiency.tcl 24.2 KB