• Oran Agra's avatar
    fix broken PEXPIREAT test (#7791) · ed9bfe22
    Oran Agra authored
    This test was nearly always failing on MacOS github actions.
    This is because of bugs in the test that caused it to nearly always run
    all 3 attempts and just look at the last one as the pass/fail creteria.
    
    i.e. the test was nearly always running all 3 attempts and still sometimes
    succeed. this is because the break condition was different than the test
    completion condition.
    
    The reason the test succeeded is because the break condition tested the
    results of all 3 tests (PSETEX/PEXPIRE/PEXPIREAT), but the success check
    at the end was only testing the result of PSETEX.
    
    The reason the PEXPIREAT test nearly always failed is because it was
    getting the current time wrong: getting the current second and loosing
    the sub-section time, so the only chance for it to succeed is if it run
    right when a certain second started.
    
    Because i now get the time from redis, adding another round trip, i
    added another 100ms to the PEXPIRE test to make it less fragile, and
    also added many more attempts.
    
    Adding many more attempts before failure to account for slow platforms,
    github actions and valgrind
    ed9bfe22
expire.tcl 6.56 KB