Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
ruanhaishen
redis
Commits
03e2bb0c
Commit
03e2bb0c
authored
Dec 11, 2018
by
antirez
Browse files
Crashing is too much in addReplyErrorLength().
See #5663.
parent
0110e46f
Changes
1
Hide whitespace changes
Inline
Side-by-side
src/networking.c
View file @
03e2bb0c
...
@@ -372,12 +372,6 @@ void addReplyErrorLength(client *c, const char *s, size_t len) {
...
@@ -372,12 +372,6 @@ void addReplyErrorLength(client *c, const char *s, size_t len) {
serverLog
(
LL_WARNING
,
"== CRITICAL == This %s is sending an error "
serverLog
(
LL_WARNING
,
"== CRITICAL == This %s is sending an error "
"to its %s: '%s' after processing the command "
"to its %s: '%s' after processing the command "
"'%s'"
,
from
,
to
,
s
,
cmdname
);
"'%s'"
,
from
,
to
,
s
,
cmdname
);
/* Here we want to panic because when a master is sending an
* error to some slave in the context of replication, this can
* only create some kind of offset or data desynchronization. Better
* to catch it ASAP and crash instead of continuing. */
if
(
c
->
flags
&
CLIENT_SLAVE
)
serverPanic
(
"Continuing is unsafe: replication protocol violation."
);
}
}
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment