Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
ruanhaishen
redis
Commits
0a89d9a0
Commit
0a89d9a0
authored
Dec 11, 2013
by
Salvatore Sanfilippo
Browse files
Merge pull request #1451 from yossigo/unbalanced-quotes-fix
Return proper error on requests with an unbalanced number of quotes.
parents
88a5cede
6e70c011
Changes
2
Hide whitespace changes
Inline
Side-by-side
src/networking.c
View file @
0a89d9a0
...
...
@@ -891,6 +891,11 @@ int processInlineBuffer(redisClient *c) {
aux
=
sdsnewlen
(
c
->
querybuf
,
querylen
);
argv
=
sdssplitargs
(
aux
,
&
argc
);
sdsfree
(
aux
);
if
(
argv
==
NULL
)
{
addReplyError
(
c
,
"Protocol error: unbalanced quotes in request"
);
setProtocolError
(
c
,
0
);
return
REDIS_ERR
;
}
/* Newline from slaves can be used to refresh the last ACK time.
* This is useful for a slave to ping back while loading a big
...
...
tests/unit/protocol.tcl
View file @
0a89d9a0
...
...
@@ -60,6 +60,14 @@ start_server {tags {"protocol"}} {
assert_error
"*wrong*arguments*ping*"
{
r ping x y z
}
}
test
"Unbalanced number of quotes"
{
reconnect
r write
"set
\"\"\"
test-key
\"\"\"
test-value
\r\n
"
r write
"ping
\r\n
"
r flush
assert_error
"*unbalanced*"
{
r read
}
}
set c 0
foreach seq
[
list
"
\x00
"
"*
\x00
"
"
$
\x00
"
]
{
incr c
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment