Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
ruanhaishen
redis
Commits
2e591fc4
Commit
2e591fc4
authored
May 25, 2020
by
antirez
Browse files
Clarify what is happening in PR #7320.
parent
cbb51fb8
Changes
1
Hide whitespace changes
Inline
Side-by-side
src/replication.c
View file @
2e591fc4
...
@@ -2537,7 +2537,11 @@ void replicationUnsetMaster(void) {
...
@@ -2537,7 +2537,11 @@ void replicationUnsetMaster(void) {
/* When a slave is turned into a master, the current replication ID
/* When a slave is turned into a master, the current replication ID
* (that was inherited from the master at synchronization time) is
* (that was inherited from the master at synchronization time) is
* used as secondary ID up to the current offset, and a new replication
* used as secondary ID up to the current offset, and a new replication
* ID is created to continue with a new replication history. */
* ID is created to continue with a new replication history.
*
* NOTE: this function MUST be called after we call
* freeClient(server.master), since there we adjust the replication
* offset trimming the final PINGs. See Github issue #7320. */
shiftReplicationId
();
shiftReplicationId
();
/* Disconnecting all the slaves is required: we need to inform slaves
/* Disconnecting all the slaves is required: we need to inform slaves
* of the replication ID change (see shiftReplicationId() call). However
* of the replication ID change (see shiftReplicationId() call). However
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment