Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
ruanhaishen
redis
Commits
2fe9b798
Commit
2fe9b798
authored
Jun 23, 2016
by
Salvatore Sanfilippo
Committed by
GitHub
Jun 23, 2016
Browse files
Merge pull request #3244 from dvirsky/optimize_autoMemoryFreed
Optimized autoMemoryFreed loop
parents
4e10b08f
137fd86a
Changes
1
Hide whitespace changes
Inline
Side-by-side
src/module.c
View file @
2fe9b798
...
@@ -611,14 +611,22 @@ void autoMemoryFreed(RedisModuleCtx *ctx, int type, void *ptr) {
...
@@ -611,14 +611,22 @@ void autoMemoryFreed(RedisModuleCtx *ctx, int type, void *ptr) {
if
(
!
(
ctx
->
flags
&
REDISMODULE_CTX_AUTO_MEMORY
))
return
;
if
(
!
(
ctx
->
flags
&
REDISMODULE_CTX_AUTO_MEMORY
))
return
;
int
j
;
int
j
;
for
(
j
=
0
;
j
<
ctx
->
amqueue_used
;
j
++
)
{
for
(
j
=
ctx
->
amqueue_used
-
1
;
j
>=
0
;
j
--
)
{
if
(
ctx
->
amqueue
[
j
].
type
==
type
&&
if
(
ctx
->
amqueue
[
j
].
type
==
type
&&
ctx
->
amqueue
[
j
].
ptr
==
ptr
)
ctx
->
amqueue
[
j
].
ptr
==
ptr
)
{
{
ctx
->
amqueue
[
j
].
type
=
REDISMODULE_AM_FREED
;
ctx
->
amqueue
[
j
].
type
=
REDISMODULE_AM_FREED
;
/* Optimization: if this is the last element, we can
* reuse it. */
/* Switch the freed element and the top element, to avoid growing
if
(
j
==
ctx
->
amqueue_used
-
1
)
ctx
->
amqueue_used
--
;
* the queue unnecessarily if we allocate/free in a loop */
if
(
j
!=
ctx
->
amqueue_used
-
1
)
{
ctx
->
amqueue
[
j
]
=
ctx
->
amqueue
[
ctx
->
amqueue_used
-
1
];
}
/* Reduce the size of the queue because we either moved the top
* element elsewhere or freed it */
ctx
->
amqueue_used
--
;
break
;
}
}
}
}
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment