Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
ruanhaishen
redis
Commits
313b2240
Commit
313b2240
authored
Jul 18, 2018
by
antirez
Browse files
In addReplyErrorLength() only panic when replying to slave.
See #5135 for more context.
parent
6183f059
Changes
1
Hide whitespace changes
Inline
Side-by-side
src/networking.c
View file @
313b2240
...
...
@@ -360,11 +360,12 @@ void addReplyErrorLength(client *c, const char *s, size_t len) {
serverLog
(
LL_WARNING
,
"== CRITICAL == This %s is sending an error "
"to its %s: '%s' after processing the command "
"'%s'"
,
from
,
to
,
s
,
cmdname
);
/* Here we want to panic because when a
n instance
is sending an
* error to
another instanc
e in the context of replication, this can
/* Here we want to panic because when a
master
is sending an
* error to
some slav
e in the context of replication, this can
* only create some kind of offset or data desynchronization. Better
* to catch it ASAP and crash instead of continuing. */
serverPanic
(
"Continuing is unsafe: replication protocol violation."
);
if
(
c
->
flags
&
CLIENT_SLAVE
)
serverPanic
(
"Continuing is unsafe: replication protocol violation."
);
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment